Skip to content

workflows: adding variable to set kokkos version to test against #2389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 19, 2024
Merged

workflows: adding variable to set kokkos version to test against #2389

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ab0230
workflows: adding variable to set kokkos version to test against
lucbv Oct 18, 2024
aac2076
workflow: fix for the osx builds
lucbv Oct 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion .github/workflows/at2.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,27 @@ concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

env:
KOKKOS_VERSION: 4.4.01

jobs:
mi210:
uses: ./.github/workflows/mi210.yml
with:
kokkos_version: 4.4.01
h100:
uses: ./.github/workflows/h100.yml
with:
kokkos_version: 4.4.01
bdw:
uses: ./.github/workflows/bdw.yml
with:
kokkos_version: 4.4.01
spr:
uses: ./.github/workflows/spr.yml
with:
kokkos_version: 4.4.01
volta70:
uses: ./.github/workflows/volta70.yml
uses: ./.github/workflows/volta70.yml
with:
kokkos_version: 4.4.01
20 changes: 13 additions & 7 deletions .github/workflows/bdw.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,17 @@
name: Reusable BDW workflow

on:
workflow_call

permissions:
contents: none

on:
workflow_call:
inputs:
kokkos_version:
description: 'The Kokkos Core version to build'
default: ''
required: true
type: string

jobs:
# PR_BDW_GNU1020_OPENMP_LEFT_REL_NOETI:
# name: PR_BDW_GNU1020_OPENMP_LEFT_REL_NOETI
Expand All @@ -21,7 +27,7 @@ jobs:
# uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1
# with:
# repository: kokkos/kokkos
# ref: ${{ github.base_ref }}
# ref: ${{ inputs.kokkos_version }}
# path: kokkos
#
# - name: configure_kokkos
Expand Down Expand Up @@ -102,7 +108,7 @@ jobs:
# uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1
# with:
# repository: kokkos/kokkos
# ref: ${{ github.base_ref }}
# ref: ${{ inputs.kokkos_version }}
# path: kokkos
#
# - name: configure_kokkos
Expand Down Expand Up @@ -184,7 +190,7 @@ jobs:
uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1
with:
repository: kokkos/kokkos
ref: ${{ github.base_ref }}
ref: ${{ inputs.kokkos_version }}
path: kokkos

- name: configure_kokkos
Expand Down Expand Up @@ -269,7 +275,7 @@ jobs:
uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1
with:
repository: kokkos/kokkos
ref: ${{ github.base_ref }}
ref: ${{ inputs.kokkos_version }}
path: kokkos

- name: configure_kokkos
Expand Down
14 changes: 10 additions & 4 deletions .github/workflows/h100.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,17 @@
name: Reusable H100 workflow

on:
workflow_call

permissions:
contents: none

on:
workflow_call:
inputs:
kokkos_version:
description: 'The Kokkos Core version to build'
default: ''
required: true
type: string

jobs:
PR_HOPPER90_CUDA1180_CUDA_LEFT_RIGHT_REL:
name: PR_HOPPER90_CUDA1180_CUDA_LEFT_RIGHT_REL
Expand All @@ -21,7 +27,7 @@ jobs:
uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1
with:
repository: kokkos/kokkos
ref: ${{ github.base_ref }}
ref: ${{ inputs.kokkos_version }}
path: kokkos

- name: configure_kokkos
Expand Down
16 changes: 11 additions & 5 deletions .github/workflows/mi210.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,17 @@
name: Reusable MI210 workflow

on:
workflow_call

permissions:
contents: none

on:
workflow_call:
inputs:
kokkos_version:
description: 'The Kokkos Core version to build'
default: ''
required: true
type: string

jobs:
PR_VEGA90A_ROCM561_HIP_SERIAL_LEFT:
name: PR_VEGA90A_ROCM561_HIP_SERIAL_LEFT
Expand All @@ -21,7 +27,7 @@ jobs:
uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1
with:
repository: kokkos/kokkos
ref: ${{ github.base_ref }}
ref: ${{ inputs.kokkos_version }}
path: kokkos

- name: configure_kokkos
Expand Down Expand Up @@ -102,7 +108,7 @@ jobs:
uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1
with:
repository: kokkos/kokkos
ref: ${{ github.base_ref }}
ref: ${{ inputs.kokkos_version }}
path: kokkos

- name: configure_kokkos
Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/osx.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

env:
KOKKOS_VERSION: 4.4.01

jobs:
check-pr-labels:
runs-on: [ubuntu-latest]
Expand Down Expand Up @@ -58,7 +61,7 @@ jobs:
uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1
with:
repository: kokkos/kokkos
ref: 4.3.01
ref: $KOKKOS_VERSION
Copy link
Contributor

@ndellingwood ndellingwood Oct 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

osx-ci doesn't like this variable, maybe braces are needed? or context?

Suggested change
ref: $KOKKOS_VERSION
ref: ${{ env.KOKKOS_VERSION }}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep that looks reasonable!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do a separate commit as I am not sure how to sign-off otherwise...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think since the checkout is performed by an action this made including the context necessary (if it was handled on the runner then the Linux shell syntax would've been fine), using-the-env-context-to-access-environment-variable-values

path: kokkos

- name: configure_kokkos
Expand Down
14 changes: 10 additions & 4 deletions .github/workflows/spr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,17 @@
name: Reusable SPR workflow

on:
workflow_call

permissions:
contents: none

on:
workflow_call:
inputs:
kokkos_version:
description: 'The Kokkos Core version to build'
default: ''
required: true
type: string

jobs:
PR_SPR_ONEAPI202310_OPENMP_LEFT_MKLBLAS_MKLLAPACK_REL:
name: PR_SPR_ONEAPI202310_OPENMP_LEFT_MKLBLAS_MKLLAPACK_REL
Expand All @@ -21,7 +27,7 @@ jobs:
uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1
with:
repository: kokkos/kokkos
ref: 4.3.01
ref: ${{ inputs.kokkos_version }}
path: kokkos

- name: configure
Expand Down
16 changes: 11 additions & 5 deletions .github/workflows/volta70.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,17 @@
name: Reusable VOLTA70 workflow

on:
workflow_call

permissions:
contents: none

on:
workflow_call:
inputs:
kokkos_version:
description: 'The Kokkos Core version to build'
default: ''
required: true
type: string

jobs:
PR_VOLTA70_CUDA1122_CUDA_LEFT_RIGHT_REL:
name: PR_VOLTA70_CUDA1122_CUDA_LEFT_RIGHT_REL
Expand All @@ -21,7 +27,7 @@ jobs:
uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1
with:
repository: kokkos/kokkos
ref: 4.4.00
ref: ${{ inputs.kokkos_version }}
path: kokkos

- name: configure_kokkos
Expand Down Expand Up @@ -87,7 +93,7 @@ jobs:
uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1
with:
repository: kokkos/kokkos
ref: 4.4.00
ref: ${{ inputs.kokkos_version }}
path: kokkos

- name: configure_kokkos
Expand Down
Loading