Skip to content

Conversation

@e10harvey
Copy link
Contributor

No description provided.

@kokkos-devops-admin kokkos-devops-admin added the AT2-SPECIAL-APPROVAL Mark .github changes as approved. label Sep 3, 2024
@kokkos-devops-admin kokkos-devops-admin added AT2-SPECIAL-APPROVAL Mark .github changes as approved. and removed AT2-SPECIAL-APPROVAL Mark .github changes as approved. labels Sep 3, 2024
@kokkos-devops-admin kokkos-devops-admin added AT2-SPECIAL-APPROVAL Mark .github changes as approved. and removed AT2-SPECIAL-APPROVAL Mark .github changes as approved. labels Sep 3, 2024
@kokkos-devops-admin kokkos-devops-admin added AT2-SPECIAL-APPROVAL Mark .github changes as approved. and removed AT2-SPECIAL-APPROVAL Mark .github changes as approved. labels Sep 3, 2024
@kokkos-devops-admin kokkos-devops-admin added AT2-SPECIAL-APPROVAL Mark .github changes as approved. and removed AT2-SPECIAL-APPROVAL Mark .github changes as approved. labels Sep 4, 2024
@kokkos-devops-admin kokkos-devops-admin added AT2-SPECIAL-APPROVAL Mark .github changes as approved. and removed AT2-SPECIAL-APPROVAL Mark .github changes as approved. labels Sep 4, 2024
Copy link
Contributor

@lucbv lucbv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable although one thing that would be good is to use the latest release of Kokkos Core, 4.4.00 at this time, as we do with the current auto-tester. I believe changing from ref: ${{ github.base_ref} to the 4.4.0 tag might be the way to handle that

@lucbv
Copy link
Contributor

lucbv commented Sep 6, 2024

Also should we actually run the volta 70 jobs to check that they run and pass before merging?

@kokkos-devops-admin kokkos-devops-admin added AT2-SPECIAL-APPROVAL Mark .github changes as approved. and removed AT2-SPECIAL-APPROVAL Mark .github changes as approved. labels Sep 11, 2024
@e10harvey
Copy link
Contributor Author

Also should we actually run the volta 70 jobs to check that they run and pass before merging?

Yea, the CLANG13CUDA check does fail a few tests with #2005.

@kokkos-devops-admin kokkos-devops-admin added AT2-SPECIAL-APPROVAL Mark .github changes as approved. and removed AT2-SPECIAL-APPROVAL Mark .github changes as approved. labels Sep 17, 2024
@kokkos-devops-admin kokkos-devops-admin added AT2-SPECIAL-APPROVAL Mark .github changes as approved. and removed AT2-SPECIAL-APPROVAL Mark .github changes as approved. labels Sep 17, 2024
@e10harvey
Copy link
Contributor Author

@ndellingwood, @lucbv: I'd like to get this PR merged, do you know the ctest regex syntax that's needed to exclude the failing tests? e.g., see 8d9a0eb

@kokkos-devops-admin kokkos-devops-admin added AT2-SPECIAL-APPROVAL Mark .github changes as approved. and removed AT2-SPECIAL-APPROVAL Mark .github changes as approved. labels Sep 18, 2024
@kokkos-devops-admin kokkos-devops-admin added AT2-SPECIAL-APPROVAL Mark .github changes as approved. and removed AT2-SPECIAL-APPROVAL Mark .github changes as approved. labels Sep 18, 2024
@lucbv
Copy link
Contributor

lucbv commented Oct 2, 2024

@e10harvey after merging the BDW PR this now needs a rebase, should be easy. Once you have it done I'll have a final look.

@lucbv
Copy link
Contributor

lucbv commented Oct 3, 2024

PR #2356 now supersedes this

@lucbv lucbv closed this Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AT2-SPECIAL-APPROVAL Mark .github changes as approved.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants