Skip to content

Update NanoAmount/NanoUnit friendly amount to support new currency symbol Ӿ #12

@bwebster4

Description

@bwebster4

Currently, when calling toString() on a NanoAmount, it produces something like "1 NANO". I am proposing that it should now return something more along the lines of "Ӿ1" or "Ӿ 1". This should be a pretty easy change, but it does require some awkwardness around appending or prepending the unit description.

In my opinion, NanoUnit needs a more general update to reflect the move away from the terms Gnano, NANO, knano, nano, mnano, etc. These days, there are just two common denominations, nano and raw. NANO, Nano, and nano mean the same thing now. I think we could get rid of these other denominations, and just use nano and raw. And then if nano, prepend "Ӿ", and if raw append "raw". Alternatively, it might be best to just leave off any sort of label, and leave that up to the user of the library.

I'd be happy to work on this myself and make a pull request. If work on this is already begun, please let me know, and if anyone has opinions on this I'd be happy to hear them.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions