Skip to content

Commit 33a01ed

Browse files
upgrade to latest dependencies (#1336)
bumping knative.dev/eventing 01d8ace...fd95228: > fd95228 Enable storage of EventType v1b2 (# 7594) > 6962251 Add a Prerequisite helper to check if the OIDC authentication feature flag is enabled (# 7609) > 341a8df [main] Update community files (# 7611) > bb5313d Remove OIDC service account, when OIDC feature is disabled again (# 7570) > 44ff98b Eventing TLS: Add scheme label to metrics (# 7581) > 8d6c6e4 Bump Go to v1.21 (# 7602) > 7cba45b Add TLS test for sequence (# 7600) Signed-off-by: Knative Automation <automation@knative.team>
1 parent 8fa6bf1 commit 33a01ed

File tree

8 files changed

+67
-12
lines changed

8 files changed

+67
-12
lines changed

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ require (
2121
k8s.io/client-go v0.28.5
2222
k8s.io/code-generator v0.28.5
2323
k8s.io/kube-openapi v0.0.0-20230928205116-a78145627833
24-
knative.dev/eventing v0.39.1-0.20240119013412-01d8acead891
24+
knative.dev/eventing v0.40.0
2525
knative.dev/hack v0.0.0-20240111013919-e89096d74d85
2626
knative.dev/pkg v0.0.0-20240116073220-b488e7be5902
2727
knative.dev/reconciler-test v0.0.0-20240116084801-50276dfba7b3

go.sum

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -842,8 +842,8 @@ k8s.io/kube-openapi v0.0.0-20230928205116-a78145627833 h1:iFFEmmB7szQhJP42AvRD2+
842842
k8s.io/kube-openapi v0.0.0-20230928205116-a78145627833/go.mod h1:AsvuZPBlUDVuCdzJ87iajxtXuR9oktsTctW/R9wwouA=
843843
k8s.io/utils v0.0.0-20230726121419-3b25d923346b h1:sgn3ZU783SCgtaSJjpcVVlRqd6GSnlTLKgpAAttJvpI=
844844
k8s.io/utils v0.0.0-20230726121419-3b25d923346b/go.mod h1:OLgZIPagt7ERELqWJFomSt595RzquPNLL48iOWgYOg0=
845-
knative.dev/eventing v0.39.1-0.20240119013412-01d8acead891 h1:jVbxj/8FFdC0SbRLbznJjTFVtKt+DJjBSR3kgoYH4eE=
846-
knative.dev/eventing v0.39.1-0.20240119013412-01d8acead891/go.mod h1:sdLjctz8g4pQJwyliGRv+7NrBDPV4O7cm4QyHVOLsUA=
845+
knative.dev/eventing v0.40.0 h1:zvMeKGBdQ5Us94Hdy7jmxpzyc1fdFnO4SS21+6nDSiU=
846+
knative.dev/eventing v0.40.0/go.mod h1:+yUUIyvX9fn9bCSH3012kc8rG7YBbjvvxwy1Kr53dRc=
847847
knative.dev/hack v0.0.0-20240111013919-e89096d74d85 h1:ERgPObDcW9LfaEPAeFvbW3UJcF3C3ul6B2ErNMv13OE=
848848
knative.dev/hack v0.0.0-20240111013919-e89096d74d85/go.mod h1:yk2OjGDsbEnQjfxdm0/HJKS2WqTLEFg/N6nUs6Rqx3Q=
849849
knative.dev/pkg v0.0.0-20240116073220-b488e7be5902 h1:H6+JJN23fhwYWCHY1339sY6uhIyoUwDy1a8dN233fdk=

vendor/knative.dev/eventing/pkg/adapter/v2/cloudevents.go

Lines changed: 16 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -210,11 +210,19 @@ func NewClient(cfg ClientConfig) (Client, error) {
210210
reporter: cfg.Reporter,
211211
crStatusEventClient: cfg.CrStatusEventClient,
212212
oidcTokenProvider: cfg.TokenProvider,
213+
scheme: "http",
213214
}
214215

215216
if cfg.Env != nil {
216217
client.audience = cfg.Env.GetAudience()
217218
client.oidcServiceAccountName = cfg.Env.GetOIDCServiceAccountName()
219+
sinkURI := cfg.Env.GetSink()
220+
if sinkURI != "" {
221+
parsedUrl, err := url.Parse(sinkURI)
222+
if err == nil {
223+
client.scheme = parsedUrl.Scheme
224+
}
225+
}
218226
}
219227

220228
return client, nil
@@ -234,12 +242,12 @@ func setTimeOut(duration time.Duration) http.Option {
234242
}
235243

236244
type client struct {
237-
ceClient cloudevents.Client
238-
ceOverrides *duckv1.CloudEventOverrides
239-
reporter source.StatsReporter
240-
crStatusEventClient *crstatusevent.CRStatusEventClient
241-
closeIdler closeIdler
242-
245+
ceClient cloudevents.Client
246+
ceOverrides *duckv1.CloudEventOverrides
247+
reporter source.StatsReporter
248+
crStatusEventClient *crstatusevent.CRStatusEventClient
249+
closeIdler closeIdler
250+
scheme string
243251
oidcTokenProvider *auth.OIDCTokenProvider
244252
audience *string
245253
oidcServiceAccountName *types.NamespacedName
@@ -302,13 +310,15 @@ func (c *client) reportMetrics(ctx context.Context, event cloudevents.Event, res
302310
if c.reporter == nil {
303311
return
304312
}
313+
305314
tags := MetricTagFromContext(ctx)
306315
reportArgs := &source.ReportArgs{
307316
Namespace: tags.Namespace,
308317
EventSource: event.Source(),
309318
EventType: event.Type(),
310319
Name: tags.Name,
311320
ResourceGroup: tags.ResourceGroup,
321+
EventScheme: c.scheme,
312322
}
313323

314324
var rres *http.RetriesResult

vendor/knative.dev/eventing/pkg/auth/serviceaccount.go

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -101,6 +101,26 @@ func EnsureOIDCServiceAccountExistsForResource(ctx context.Context, serviceAccou
101101
return nil
102102
}
103103

104+
// DeleteOIDCServiceAccountIfExists makes sure the given resource does not have an OIDC service account.
105+
// If it does that service account is deleted.
106+
func DeleteOIDCServiceAccountIfExists(ctx context.Context, serviceAccountLister corev1listers.ServiceAccountLister, kubeclient kubernetes.Interface, gvk schema.GroupVersionKind, objectMeta metav1.ObjectMeta) error {
107+
saName := GetOIDCServiceAccountNameForResource(gvk, objectMeta)
108+
sa, err := serviceAccountLister.ServiceAccounts(objectMeta.Namespace).Get(saName)
109+
110+
if err == nil && metav1.IsControlledBy(&sa.ObjectMeta, &objectMeta) {
111+
logging.FromContext(ctx).Debugf("OIDC Service account exists and has correct owner (%s/%s). Deleting OIDC service account", objectMeta.Name, objectMeta.Namespace)
112+
113+
err = kubeclient.CoreV1().ServiceAccounts(objectMeta.Namespace).Delete(ctx, sa.Name, metav1.DeleteOptions{})
114+
if err != nil {
115+
return fmt.Errorf("could not delete OIDC service account %s/%s for %s: %w", objectMeta.Name, objectMeta.Namespace, gvk.Kind, err)
116+
}
117+
} else if apierrs.IsNotFound(err) {
118+
return nil
119+
}
120+
121+
return err
122+
}
123+
104124
type OIDCIdentityStatusMarker interface {
105125
MarkOIDCIdentityCreatedSucceeded()
106126
MarkOIDCIdentityCreatedSucceededWithReason(reason, messageFormat string, messageA ...interface{})
@@ -119,6 +139,9 @@ func SetupOIDCServiceAccount(ctx context.Context, flags feature.Flags, serviceAc
119139
}
120140
marker.MarkOIDCIdentityCreatedSucceeded()
121141
} else {
142+
if err := DeleteOIDCServiceAccountIfExists(ctx, serviceAccountLister, kubeclient, gvk, objectMeta); err != nil {
143+
return err
144+
}
122145
setAuthStatus(nil)
123146
marker.MarkOIDCIdentityCreatedSucceededWithReason(fmt.Sprintf("%s feature disabled", feature.OIDCAuthentication), "")
124147
}

vendor/knative.dev/eventing/pkg/metrics/metrics.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,9 @@ const (
4545
// LabelEventType is the label for the name of the event type.
4646
LabelEventType = "event_type"
4747

48+
// LabelEventType is the label for the name of the event type.
49+
LabelEventScheme = "event_scheme"
50+
4851
// LabelEventSource is the label for the name of the event source.
4952
LabelEventSource = "event_source"
5053

vendor/knative.dev/eventing/pkg/metrics/source/stats_reporter.go

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ var (
5050
namespaceKey = tag.MustNewKey(eventingmetrics.LabelNamespaceName)
5151
eventSourceKey = tag.MustNewKey(eventingmetrics.LabelEventSource)
5252
eventTypeKey = tag.MustNewKey(eventingmetrics.LabelEventType)
53+
eventScheme = tag.MustNewKey(eventingmetrics.LabelEventScheme)
5354
sourceNameKey = tag.MustNewKey(eventingmetrics.LabelName)
5455
sourceResourceGroupKey = tag.MustNewKey(eventingmetrics.LabelResourceGroup)
5556
responseCodeKey = tag.MustNewKey(eventingmetrics.LabelResponseCode)
@@ -62,6 +63,7 @@ var (
6263
type ReportArgs struct {
6364
Namespace string
6465
EventType string
66+
EventScheme string
6567
EventSource string
6668
Name string
6769
ResourceGroup string
@@ -122,6 +124,7 @@ func (r *reporter) generateTag(args *ReportArgs, responseCode int) (context.Cont
122124
tag.Insert(namespaceKey, args.Namespace),
123125
tag.Insert(eventSourceKey, args.EventSource),
124126
tag.Insert(eventTypeKey, args.EventType),
127+
tag.Insert(eventScheme, args.EventScheme),
125128
tag.Insert(sourceNameKey, args.Name),
126129
tag.Insert(sourceResourceGroupKey, args.ResourceGroup),
127130
metrics.MaybeInsertIntTag(responseCodeKey, responseCode, responseCode > 0),
@@ -135,12 +138,14 @@ func register() {
135138
namespaceKey,
136139
eventSourceKey,
137140
eventTypeKey,
141+
eventScheme,
138142
sourceNameKey,
139143
sourceResourceGroupKey,
140144
responseCodeKey,
141145
responseCodeClassKey,
142146
responseError,
143-
responseTimeout}
147+
responseTimeout,
148+
}
144149

145150
// Create view to see our measurements.
146151
if err := view.Register(

vendor/knative.dev/eventing/test/rekt/features/featureflags/featureflags.go

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,20 @@ func TransportEncryptionStrict() feature.ShouldRun {
6060
}
6161
}
6262

63+
func AuthenticationOIDCEnabled() feature.ShouldRun {
64+
return func(ctx context.Context, t feature.T) (feature.PrerequisiteResult, error) {
65+
flags, err := getFeatureFlags(ctx, "config-features")
66+
if err != nil {
67+
return feature.PrerequisiteResult{}, err
68+
}
69+
70+
return feature.PrerequisiteResult{
71+
ShouldRun: flags.IsOIDCAuthentication(),
72+
Reason: flags.String(),
73+
}, nil
74+
}
75+
}
76+
6377
func IstioDisabled() feature.ShouldRun {
6478
return func(ctx context.Context, t feature.T) (feature.PrerequisiteResult, error) {
6579
flags, err := getFeatureFlags(ctx, "config-features")

vendor/modules.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1084,8 +1084,8 @@ k8s.io/utils/pointer
10841084
k8s.io/utils/ptr
10851085
k8s.io/utils/strings/slices
10861086
k8s.io/utils/trace
1087-
# knative.dev/eventing v0.39.1-0.20240119013412-01d8acead891
1088-
## explicit; go 1.19
1087+
# knative.dev/eventing v0.40.0
1088+
## explicit; go 1.21
10891089
knative.dev/eventing/cmd/heartbeats
10901090
knative.dev/eventing/pkg/adapter/v2
10911091
knative.dev/eventing/pkg/adapter/v2/util/crstatusevent

0 commit comments

Comments
 (0)