[release-1.17] Run keda obj deletion only if the feature was previously enabled, to avoid GET requests for KEDA resources against the API server on each reconcilation (#4385)

* Run keda obj deletion only if the feature was previously enabled, to avoid GET requests for KEDA resources against the API server on each reconcilation

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* lipstick: make string constant

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

---------

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
Co-authored-by: Matthias Wessendorf <mwessend@redhat.com>

Author: knative-prow-robot

control-plane/pkg/apis/internalskafkaeventing/v1alpha1/consumer_group_lifecycle.go

@@ -26,6 +26,7 @@ const (
 	ConditionConsumerGroupConsumers          apis.ConditionType = "Consumers"
 	ConditionConsumerGroupConsumersScheduled apis.ConditionType = "ConsumersScheduled"
 	ConditionAutoscaling                     apis.ConditionType = "Autoscaler"
+	AutoscalerDisabled                                          = "AutoscalerDisabled"
 	// Labels
 	KafkaChannelNameLabel           = "kafkachannel-name"
 	ConsumerLabelSelector           = "kafka.eventing.knative.dev/metadata.uid"
@@ -98,7 +99,7 @@ func (cg *ConsumerGroup) MarkAutoscalerSucceeded() {
 }
 
 func (cg *ConsumerGroup) MarkAutoscalerDisabled() {
-	cg.GetConditionSet().Manage(cg.GetStatus()).MarkTrueWithReason(ConditionAutoscaling, "Autoscaler is disabled", "")
+	cg.GetConditionSet().Manage(cg.GetStatus()).MarkTrueWithReason(ConditionAutoscaling, AutoscalerDisabled, "")
 }
 
 func (cg *ConsumerGroup) MarkAutoscalerFailed(reason string, err error) error {

control-plane/pkg/apis/internalskafkaeventing/v1alpha1/consumer_group_types.go

@@ -232,6 +232,18 @@ func (cg *ConsumerGroup) IsNotScheduled() bool {
 	return cond.IsFalse() || cond.IsUnknown()
 }
 
+func (cg *ConsumerGroup) IsAutoscalerNotDisabled() bool {
+	condition := cg.Status.GetCondition(ConditionAutoscaling)
+
+	// If condition doesn't exist or is not true, it's not in "disabled" state
+	if condition == nil || condition.Status != corev1.ConditionTrue {
+		return true
+	}
+
+	// If condition is True but reason is not "autoscaler is disabled", then it's actively enabled
+	return condition.Reason != AutoscalerDisabled
+}
+
 func (cg *ConsumerGroup) HasDeadLetterSink() bool {
 	return hasDeadLetterSink(cg.Spec.Template.Spec.Delivery)
 }

control-plane/pkg/reconciler/consumergroup/consumergroup.go

@@ -211,11 +211,18 @@ func (r *Reconciler) ReconcileKind(ctx context.Context, cg *kafkainternals.Consu
 		}
 		cg.MarkAutoscalerSucceeded()
 	} else {
-		// If KEDA is not installed or autoscaler feature disabled, do nothing
-		cg.MarkAutoscalerDisabled()
-		if err := r.deleteKedaObjects(ctx, cg); err != nil {
-			return err
+
+		// If KEDA autoscaler feature is disabled, we need to check if it was enabled before
+		// check if the conditoion is not yet AutoscalerDisabled, only than delete KEDA objects
+		if cg.IsAutoscalerNotDisabled() {
+			logger.Debugw("Deleting KEDA objects as autoscaler is being disabled")
+			if err := r.deleteKedaObjects(ctx, cg); err != nil {
+				return err
+			}
 		}
+
+		// Mark as disabled after successful deletion, or if the feature was already disabled
+		cg.MarkAutoscalerDisabled()
 	}
 
 	logger.Debugw("Reconciling consumers")