fix: only add triggerAuth to scaled objects when there is an actual value to reference (#3943)

knative-prow-robot · Cali0707 · web-flow · commit e77b72c10271 · 2024-07-04T19:06:22.000Z
Signed-off-by: Calum Murray &lt;cmurray@redhat.com&gt;
Co-authored-by: Calum Murray &lt;cmurray@redhat.com&gt;
diff --git a/control-plane/pkg/autoscaler/keda/keda.go b/control-plane/pkg/autoscaler/keda/keda.go
@@ -77,13 +77,14 @@ func GenerateScaleTriggers(cg *kafkainternals.ConsumerGroup, triggerAuthenticati
 		}
 
 		trigger := kedav1alpha1.ScaleTriggers{
-			Type:              "kafka",
-			Metadata:          triggerMetadata,
-			AuthenticationRef: &kedav1alpha1.ScaledObjectAuthRef{},
+			Type:     "kafka",
+			Metadata: triggerMetadata,
 		}
 
 		if triggerAuthentication != nil {
-			trigger.AuthenticationRef.Name = triggerAuthentication.Name
+			trigger.AuthenticationRef = &kedav1alpha1.ScaledObjectAuthRef{
+				Name: triggerAuthentication.Name,
+			}
 		}
 
 		triggers = append(triggers, trigger)

Original file line number	Diff line number	Diff line change
`@@ -77,13 +77,14 @@ func GenerateScaleTriggers(cg *kafkainternals.ConsumerGroup, triggerAuthenticati`
`77`	`77`	`}`
`78`	`78`
`79`	`79`	`trigger := kedav1alpha1.ScaleTriggers{`
`80`		`- Type: "kafka",`
`81`		`- Metadata: triggerMetadata,`
`82`		`- AuthenticationRef: &kedav1alpha1.ScaledObjectAuthRef{},`
	`80`	`+ Type: "kafka",`
	`81`	`+ Metadata: triggerMetadata,`
`83`	`82`	`}`
`84`	`83`
`85`	`84`	`if triggerAuthentication != nil {`
`86`		`- trigger.AuthenticationRef.Name = triggerAuthentication.Name`
	`85`	`+ trigger.AuthenticationRef = &kedav1alpha1.ScaledObjectAuthRef{`
	`86`	`+ Name: triggerAuthentication.Name,`
	`87`	`+ }`
`87`	`88`	`}`
`88`	`89`
`89`	`90`	`triggers = append(triggers, trigger)`