Use Go 1.23 (#14)

* Use Go 1.23

Signed-off-by: 1gtm <1gtm@appscode.com>

* Fix linter

Signed-off-by: rasel <rasel@appscode.com>

---------

Signed-off-by: 1gtm <1gtm@appscode.com>
Signed-off-by: rasel <rasel@appscode.com>
Co-authored-by: rasel <rasel@appscode.com>

Author: 1gtm

.github/workflows/ci.yml

@@ -16,13 +16,13 @@ concurrency:
 jobs:
   build:
     name: Build
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-24.04
     steps:
 
-      - name: Set up Go 1.20
+      - name: Set up Go 1.23
         uses: actions/setup-go@v1
         with:
-          go-version: '1.20'
+          go-version: '1.23'
         id: go
 
       - uses: actions/checkout@v2

.github/workflows/release-tracker.yml

@@ -11,7 +11,7 @@ concurrency:
 
 jobs:
   build:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-24.04
 
     steps:
       - uses: actions/checkout@v1

.github/workflows/release.yml

@@ -14,7 +14,7 @@ concurrency:
 jobs:
   build:
     name: Build
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-24.04
     steps:
       - uses: actions/checkout@v1
 

Makefile

@@ -77,9 +77,9 @@ TAG              := $(VERSION)_$(OS)_$(ARCH)
 TAG_PROD         := $(TAG)
 TAG_DBG          := $(VERSION)-dbg_$(OS)_$(ARCH)
 
-GO_VERSION       ?= 1.22
+GO_VERSION       ?= 1.23
 BUILD_IMAGE      ?= ghcr.io/appscode/golang-dev:$(GO_VERSION)
-CHART_TEST_IMAGE ?= quay.io/helmpack/chart-testing:v3.5.1
+CHART_TEST_IMAGE ?= quay.io/helmpack/chart-testing:v3.11.0
 
 OUTBIN = bin/$(BIN)-$(OS)-$(ARCH)
 ifeq ($(OS),windows)

pkg/controller/aws.go

@@ -230,7 +230,7 @@ func deleteAwsInternetGateway(c *ec2.EC2, gatewayId, vpcId string) error {
 	})
 	if err != nil {
 		if strings.Contains(err.Error(), "does not exist") {
-			klog.Warningf(err.Error())
+			klog.Warning(err.Error())
 			return nil
 		}
 		return err
@@ -280,7 +280,7 @@ func (r *MachineReconciler) deleteAwsSubnet(c *ec2.EC2, subnetId string) error {
 	})
 	if err != nil {
 		if strings.Contains(err.Error(), "does not exist") {
-			klog.Warningf(err.Error())
+			klog.Warning(err.Error())
 			return nil
 		}
 		return err
@@ -379,7 +379,7 @@ func (r *MachineReconciler) deleteAwsVpc(c *ec2.EC2, vpcID string) error {
 	})
 	if err != nil {
 		if strings.Contains(err.Error(), "does not exist") {
-			klog.Warningf(err.Error())
+			klog.Warning(err.Error())
 			return nil
 		}
 		return err
@@ -408,7 +408,7 @@ func deleteSecurityGroup(c *ec2.EC2, vpcId string) error {
 			GroupId: sg.GroupId,
 		})
 		if err != nil {
-			klog.Warningf(fmt.Sprintf("failed to delete security group: %s", *sg.GroupId))
+			klog.Warningf("failed to delete security group: %s", *sg.GroupId)
 		}
 		klog.Infof("%s deleted", *sg.GroupId)
 	}

pkg/controller/machine.go

@@ -71,7 +71,7 @@ func (r *MachineReconciler) createMachine() error {
 	if err != nil && !strings.Contains(commandError.String(), "already exists") {
 		r.Log.Info("Error creating docker machine", "Error: ", commandError.String(), "Output: ", commandOutput.String())
 		cutil.MarkFalse(r.machineObj, api.MachineConditionTypeMachineReady, api.ReasonMachineCreationFailed, kmapi.ConditionSeverityError,
-			fmt.Sprintf("Unable to create docker machine. err : %s", err.Error()))
+			"unable to create docker machine. err: %s", err.Error())
 
 		return err
 	}

pkg/script/ami.sh

@@ -14,8 +14,6 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-
-
 regions=$(aws ec2 describe-regions --query "Regions[].RegionName" --output json | jq -r '.[]')
 
 for region in $regions; do