Fix ElementNotInteractableException (#176)

Author: cal4

CHANGELOG.md

@@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.2.1] - 2024-08-13
+
+### Fixed
+
+- [Fix ElementNotInteractableException](https://github.com/klept0/MS-Rewards-Farmer/pull/176)
+
 ## [0.2.0] - 2024-08-09
 
 ### Added

src/activities.py

@@ -13,16 +13,16 @@ def __init__(self, browser: Browser):
 
     def openDailySetActivity(self, cardId: int):
         # Open the Daily Set activity for the given cardId
-        self.webdriver.find_element(
-            By.XPATH,
-            f'//*[@id="daily-sets"]/mee-card-group[1]/div/mee-card[{cardId}]/div/card-content/mee-rewards-daily-set-item-content/div/a',
-        ).click()
+        element = self.webdriver.find_element(By.XPATH,
+                                              f'//*[@id="daily-sets"]/mee-card-group[1]/div/mee-card[{cardId}]/div/card-content/mee-rewards-daily-set-item-content/div/a', )
+        self.browser.utils.click(element)
         self.browser.utils.switchToNewTab(timeToWait=8)
 
     def openMorePromotionsActivity(self, cardId: int):
         # Open the More Promotions activity for the given cardId
-        self.webdriver.find_element(By.CSS_SELECTOR,
-                                    f"#more-activities > .m-card-group > .ng-scope:nth-child({cardId + 1}) .ds-card-sec").click()
+        element = self.webdriver.find_element(By.CSS_SELECTOR,
+                                              f"#more-activities > .m-card-group > .ng-scope:nth-child({cardId + 1}) .ds-card-sec")
+        self.browser.utils.click(element)
         self.browser.utils.switchToNewTab(timeToWait=5)
 
     def completeSearch(self):

src/searches.py

@@ -170,7 +170,7 @@ def bingSearch(self) -> None:
                 By.ID, "sb_form_q", timeToWait=20
             )
             for _ in range(1000):
-                searchbar.click()
+                self.browser.utils.click(searchbar)
                 searchbar.clear()
                 term = next(termsCycle)
                 logging.debug(f"term={term}")

src/utils.py

@@ -13,7 +13,8 @@
 from apprise import Apprise
 from requests import Session
 from requests.adapters import HTTPAdapter
-from selenium.common import NoSuchElementException, TimeoutException
+from selenium.common import NoSuchElementException, TimeoutException, ElementClickInterceptedException, \
+    ElementNotInteractableException
 from selenium.webdriver.chrome.webdriver import WebDriver
 from selenium.webdriver.common.by import By
 from selenium.webdriver.remote.webelement import WebElement
@@ -175,30 +176,29 @@ def tryDismissAllMessages(self) -> None:
             (By.ID, "iNext"),
             (By.ID, "iLooksGood"),
             (By.ID, "idSIButton9"),
-            (By.CSS_SELECTOR, ".ms-Button.ms-Button--primary"),
             (By.ID, "bnp_btn_accept"),
             (By.ID, "acceptButton"),
         ]
         for button in buttons:
             try:
                 elements = self.webdriver.find_elements(by=button[0], value=button[1])
-            except NoSuchElementException:  # Expected?
+            except (NoSuchElementException, ElementNotInteractableException):  # Expected?
                 logging.debug("", exc_info=True)
                 continue
             for element in elements:
                 element.click()
+        self.tryDismissCookieBanner()
+        self.tryDismissBingCookieBanner()
 
     def tryDismissCookieBanner(self) -> None:
-        with contextlib.suppress(NoSuchElementException):  # Expected
+        with contextlib.suppress(NoSuchElementException, ElementNotInteractableException):  # Expected
             self.webdriver.find_element(By.ID, "cookie-banner").find_element(
                 By.TAG_NAME, "button"
             ).click()
-            time.sleep(2)
 
     def tryDismissBingCookieBanner(self) -> None:
-        with contextlib.suppress(NoSuchElementException):  # Expected
+        with contextlib.suppress(NoSuchElementException, ElementNotInteractableException):  # Expected
             self.webdriver.find_element(By.ID, "bnp_btn_accept").click()
-            time.sleep(2)
 
     def switchToNewTab(self, timeToWait: float = 0) -> None:
         time.sleep(0.5)
@@ -235,3 +235,10 @@ def saveBrowserConfig(sessionPath: Path, config: dict) -> None:
         configFile = sessionPath / "config.json"
         with open(configFile, "w") as f:
             json.dump(config, f)
+
+    def click(self, element: WebElement) -> None:
+        try:
+            element.click()
+        except ElementClickInterceptedException:
+            self.tryDismissAllMessages()
+            element.click()