Skip to content

Commit 7ffaa60

Browse files
committed
Fix "Script Data" being shown on no-input scripts
1 parent 8c90c2d commit 7ffaa60

File tree

3 files changed

+8
-3
lines changed

3 files changed

+8
-3
lines changed

CHANGELOG.md

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,4 +46,8 @@
4646

4747
# 0.3.7
4848

49-
* Fix "Create" changelogs not being created when a scheduled script is re-enqueued.
49+
* Fix "Create" changelogs not being created when a scheduled script is re-enqueued.
50+
51+
# 0.3.8
52+
53+
* Fix "Script Data" being shown on no-input scripts

netbox_script_manager/navigation.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
PluginMenuItem(
66
link="plugins:netbox_script_manager:scriptinstance_list",
77
link_text="Scripts",
8+
permissions=["netbox_script_manager.view_scriptinstance"],
89
buttons=(
910
PluginMenuButton(
1011
link="plugins:netbox_script_manager:scriptinstance_load",
@@ -18,5 +19,6 @@
1819
PluginMenuItem(
1920
link="plugins:netbox_script_manager:scriptexecution_list",
2021
link_text="Executions",
22+
permissions=["netbox_script_manager.view_scriptexecution"],
2123
),
2224
)

netbox_script_manager/scripts.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -134,8 +134,7 @@ def get_fieldsets(self, instance=None):
134134
if self.fieldsets:
135135
fieldsets.extend(self.fieldsets)
136136
else:
137-
fields = (name for name, _ in self._get_vars().items())
138-
fieldsets.append(("Script Data", fields))
137+
fieldsets.append(("Script Data", self._get_vars().keys()))
139138

140139
# Append the default fieldset if defined in the Meta class
141140
exec_parameters = ["_schedule_at", "_interval", "_task_queue", "_commit"] if self.scheduling_enabled else ["_task_queue", "_commit"]

0 commit comments

Comments
 (0)