Skip to content

Commit 6ae5935

Browse files
committed
Clean up API by creating nested serializers
1 parent fd76be0 commit 6ae5935

File tree

1 file changed

+15
-12
lines changed

1 file changed

+15
-12
lines changed

netbox_script_manager/api/serializers.py

Lines changed: 15 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -61,21 +61,13 @@ class Meta:
6161
"id",
6262
"url",
6363
"name",
64-
"group",
65-
"weight",
66-
"module_path",
67-
"class_name",
6864
"display",
69-
"task_queues",
70-
"tags",
71-
"created",
72-
"last_updated",
7365
)
7466

7567

7668
class ScriptExecutionSerializer(NetBoxModelSerializer):
7769
url = serializers.HyperlinkedIdentityField(view_name="plugins-api:netbox_script_manager-api:scriptexecution-detail")
78-
script_instance = ScriptInstanceSerializer(read_only=True)
70+
script_instance = NestedScriptInstanceSerializer(read_only=True)
7971

8072
class Meta:
8173
model = ScriptExecution
@@ -94,9 +86,21 @@ class Meta:
9486
)
9587

9688

89+
class NestedScriptExecutionSerializer(NetBoxModelSerializer):
90+
url = serializers.HyperlinkedIdentityField(view_name="plugins-api:netbox_script_manager-api:scriptexecution-detail")
91+
92+
class Meta:
93+
model = ScriptExecution
94+
fields = (
95+
"id",
96+
"url",
97+
"display",
98+
"status",
99+
)
100+
101+
97102
class ScriptLogLineSerializer(NetBoxModelSerializer):
98103
url = serializers.HyperlinkedIdentityField(view_name="plugins-api:netbox_script_manager-api:scriptlogline-detail")
99-
script_execution = ScriptExecutionSerializer(read_only=True)
100104
message_markdown = MarkdownField(source="message", read_only=True)
101105
timestamp_formatted = FormattedDateTimeField(source="timestamp", read_only=True)
102106

@@ -106,7 +110,6 @@ class Meta:
106110
"id",
107111
"url",
108112
"display",
109-
"script_execution",
110113
"level",
111114
"message",
112115
"message_markdown",
@@ -134,7 +137,7 @@ class Meta:
134137

135138
class ScriptArtifactSerializer(NetBoxModelSerializer):
136139
url = serializers.HyperlinkedIdentityField(view_name="plugins-api:netbox_script_manager-api:scriptartifact-detail")
137-
script_execution = ScriptExecutionSerializer(read_only=True)
140+
script_execution = NestedScriptExecutionSerializer(read_only=True)
138141

139142
class Meta:
140143
model = ScriptArtifact

0 commit comments

Comments
 (0)