Skip to content

Commit 9c4c91b

Browse files
committed
Revert "Disabled non-working tests until issues have been fixed"
This reverts commit 314b330.
1 parent 314b330 commit 9c4c91b

File tree

10 files changed

+5
-28
lines changed

10 files changed

+5
-28
lines changed

src/test/java/edu/kit/datamanager/ro_crate/crate/OtherFilesTest.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,15 +18,13 @@
1818

1919
import static org.junit.jupiter.api.Assertions.assertFalse;
2020
import static org.junit.jupiter.api.Assertions.assertTrue;
21-
import org.junit.jupiter.api.Disabled;
2221

23-
@Disabled("Disabled while issues are being fixed!")
2422
public class OtherFilesTest {
2523

2624
/**
2725
* Test if adding untracked files to the crate a being included inside it
2826
*/
29-
@Test
27+
@Test
3028
void testOtherFiles(@TempDir Path tempDir) throws IOException, URISyntaxException {
3129
Path crate = tempDir.resolve("crate");
3230
Path file1 = tempDir.resolve("file1.txt");

src/test/java/edu/kit/datamanager/ro_crate/crate/SerializationTest.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,15 +14,13 @@
1414
import edu.kit.datamanager.ro_crate.entities.data.FileEntity;
1515

1616
import org.apache.commons.io.FileUtils;
17-
import org.junit.jupiter.api.Disabled;
1817
import org.junit.jupiter.api.Test;
1918
import org.junit.jupiter.api.io.TempDir;
2019

2120
/**
2221
* @author Nikola Tzotchev on 6.2.2022 г.
2322
* @version 1
2423
*/
25-
@Disabled("Disabled while issues are being fixed!")
2624
public class SerializationTest {
2725

2826
@Test

src/test/java/edu/kit/datamanager/ro_crate/crate/TestRemoveAddEntity.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,7 @@
1313
import static org.junit.jupiter.api.Assertions.assertEquals;
1414

1515
import java.io.IOException;
16-
import org.junit.jupiter.api.Disabled;
1716

18-
@Disabled("Disabled while issues are being fixed!")
1917
public class TestRemoveAddEntity {
2018
@Test
2119
void testAddRemoveEntity() throws IOException {

src/test/java/edu/kit/datamanager/ro_crate/crate/preview/PreviewCrateTest.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,9 @@
1717

1818
import static org.junit.jupiter.api.Assertions.assertFalse;
1919
import static org.junit.jupiter.api.Assertions.assertTrue;
20-
import org.junit.jupiter.api.Disabled;
2120

2221
public class PreviewCrateTest {
23-
24-
@Disabled("Disabled while issues are being fixed!")
22+
2523
@Test
2624
void testAutomaticPreview(@TempDir Path temp) {
2725
Path location = temp.resolve("ro_crate1");
@@ -33,7 +31,6 @@ void testAutomaticPreview(@TempDir Path temp) {
3331
assertTrue(Files.isRegularFile(location.resolve("ro-crate-preview.html")));
3432
}
3533

36-
@Disabled("Disabled while issues are being fixed!")
3734
@Test
3835
void testAutomaticPreviewAddingLater(@TempDir Path temp) {
3936
Path location = temp.resolve("ro_crate2");

src/test/java/edu/kit/datamanager/ro_crate/entities/data/RootDataEntityTest.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
import edu.kit.datamanager.ro_crate.RoCrate;
1111
import static org.junit.jupiter.api.Assertions.assertEquals;
1212
import static org.junit.jupiter.api.Assertions.assertNotNull;
13-
import org.junit.jupiter.api.Disabled;
1413

1514
import org.junit.jupiter.api.Test;
1615

@@ -54,7 +53,6 @@ void testSerialization() throws IOException {
5453
HelpFunctions.compareEntityWithFile(rootDataEntity, "/json/entities/data/root.json");
5554
}
5655

57-
@Disabled("Disabled while issues are being fixed!")
5856
@Test
5957
void testSerializationMinimalExample() throws IOException {
6058
RootDataEntity rootDataEntity = new RootDataEntity.RootDataEntityBuilder()

src/test/java/edu/kit/datamanager/ro_crate/externalproviders/OrcidProviderTest.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,15 +10,13 @@
1010
import static org.junit.jupiter.api.Assertions.assertNotNull;
1111
import static org.junit.jupiter.api.Assertions.assertNull;
1212
import static org.junit.jupiter.api.Assertions.assertThrows;
13-
import org.junit.jupiter.api.Disabled;
1413

1514
/**
1615
* @author Nikola Tzotchev on 10.2.2022 г.
1716
* @version 1
1817
*/
1918
public class OrcidProviderTest {
20-
21-
@Disabled("Disabled while issues are being fixed!")
19+
2220
@Test
2321
void testAddingPersonEntity() throws IOException {
2422
PersonEntity person = OrcidProvider.getPerson("https://orcid.org/0000-0001-9842-9718");

src/test/java/edu/kit/datamanager/ro_crate/externalproviders/ZenodoImportTest.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,9 @@
88
import edu.kit.datamanager.ro_crate.validation.Validator;
99

1010
import static org.junit.jupiter.api.Assertions.assertTrue;
11-
import org.junit.jupiter.api.Disabled;
1211

1312
public class ZenodoImportTest {
1413

15-
@Disabled("Disabled while issues are being fixed!")
1614
@Test
1715
void testImportingNewCrate() {
1816
String url = "https://zenodo.org/api/records/6411574";

src/test/java/edu/kit/datamanager/ro_crate/preview/PreviewTest.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414

1515
import static org.junit.jupiter.api.Assertions.assertFalse;
1616
import static org.junit.jupiter.api.Assertions.assertTrue;
17-
import org.junit.jupiter.api.Disabled;
1817

1918
public class PreviewTest {
2019

@@ -74,8 +73,7 @@ void customPreviewSaveToZip(@TempDir Path dir) throws IOException {
7473
assertTrue(FileUtils.contentEqualsIgnoreEOL(roDirFile.toFile(), fileInDir.toFile(), String.valueOf(Charset.defaultCharset())));
7574

7675
}
77-
78-
@Disabled("Disabled while issues are being fixed!")
76+
7977
@Test
8078
void testAutomaticPreviewAddToFolder(@TempDir Path dir) throws IOException {
8179
AutomaticPreview automaticPreview = new AutomaticPreview();
@@ -96,7 +94,6 @@ void testAutomaticPreviewAddToFolder(@TempDir Path dir) throws IOException {
9694
assertTrue(Files.isRegularFile(crate.resolve("ro-crate-preview.html")));
9795
}
9896

99-
@Disabled("Disabled while issues are being fixed!")
10097
@Test
10198
void testAutomaticPreviewZip(@TempDir Path dir) throws IOException {
10299
AutomaticPreview automaticPreview = new AutomaticPreview();

src/test/java/edu/kit/datamanager/ro_crate/writer/FolderWriterTest.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
import edu.kit.datamanager.ro_crate.preview.PreviewGenerator;
1919

2020
import org.apache.commons.io.FileUtils;
21-
import org.junit.jupiter.api.Disabled;
2221
import org.junit.jupiter.api.Test;
2322
import org.junit.jupiter.api.io.TempDir;
2423

@@ -90,7 +89,6 @@ void writeToFolderCorrectNames(@TempDir Path tempDir) throws IOException {
9089
assertTrue(Files.isRegularFile(result.resolve(fileWithoutID.getFileName())));
9190
}
9291

93-
@Disabled("Disabled while issues are being fixed!")
9492
@Test
9593
void writeToFolderTest(@TempDir Path tempDir) throws IOException {
9694
RoCrateWriter folderRoCrateWriter = new RoCrateWriter(new FolderWriter());
@@ -154,8 +152,7 @@ void writeToFolderTest(@TempDir Path tempDir) throws IOException {
154152
// just so we know the metadata is still valid
155153
HelpFunctions.compareCrateJsonToFileInResources(roCrate, "/json/crate/fileAndDir.json");
156154
}
157-
158-
@Disabled("Disabled while issues are being fixed!")
155+
159156
@Test
160157
void writeToFolderWrongTest(@TempDir Path tempDir) throws IOException {
161158
RoCrateWriter folderRoCrateWriter = new RoCrateWriter(new FolderWriter());

src/test/java/edu/kit/datamanager/ro_crate/writer/ZipWriterTest.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,15 +16,13 @@
1616
import edu.kit.datamanager.ro_crate.preview.PreviewGenerator;
1717
import net.lingala.zip4j.ZipFile;
1818
import org.apache.commons.io.FileUtils;
19-
import org.junit.jupiter.api.Disabled;
2019
import org.junit.jupiter.api.Test;
2120
import org.junit.jupiter.api.io.TempDir;
2221

2322
/**
2423
* @author Nikola Tzotchev on 9.2.2022 г.
2524
* @version 1
2625
*/
27-
@Disabled("Disabled while issues are being fixed!")
2826
public class ZipWriterTest {
2927

3028
@Test

0 commit comments

Comments
 (0)