fix: misleading variable names and useless checks

Author: Pfeil

src/main/java/edu/kit/datamanager/ro_crate/externalproviders/organizationprovider/RorProvider.java

@@ -41,8 +41,8 @@ public static OrganizationEntity getOrganization(String url) {
       CloseableHttpClient httpClient = HttpClients.createDefault();
       CloseableHttpResponse response = httpClient.execute(request);
     ) {
-        boolean isOk = response.getStatusLine().getStatusCode() != HttpStatus.SC_OK;
-        if (isOk) {
+        boolean isError = response.getStatusLine().getStatusCode() != HttpStatus.SC_OK;
+        if (isError) {
           String errorMessage = String.format("Identifier not found: %s", response.getStatusLine().toString());
           logger.error(errorMessage);
           return null;

src/main/java/edu/kit/datamanager/ro_crate/externalproviders/personprovider/OrcidProvider.java

@@ -48,10 +48,11 @@ public static PersonEntity getPerson(String url) {
       CloseableHttpClient httpClient = HttpClients.createDefault();
       CloseableHttpResponse response = httpClient.execute(request);
     ) {
-      boolean isOk = response.getStatusLine().getStatusCode() != HttpStatus.SC_OK;
-      boolean isJson = response.containsHeader(HttpHeaders.CONTENT_TYPE)
-        && response.getFirstHeader(HttpHeaders.CONTENT_TYPE).getValue().equals(ContentType.TEXT_HTML.toString());
-      if (isOk && isJson) {
+      boolean isError = response.getStatusLine().getStatusCode() != HttpStatus.SC_OK;
+      String receivedMimeType = ContentType.parse(response.getFirstHeader(HttpHeaders.CONTENT_TYPE).getValue()).getMimeType();
+      boolean isUnexpectedFormat = response.containsHeader(HttpHeaders.CONTENT_TYPE)
+        && !receivedMimeType.equals("application/ld+json");
+      if (isError || isUnexpectedFormat) {
         String errorMessage = String.format("Identifier not found: %s", response.getStatusLine().toString());
         logger.error(errorMessage);
         return null;