Skip to content

Commit 10fa3e6

Browse files
committed
Fix borders and text color in dark mode popups
1 parent b1aede6 commit 10fa3e6

File tree

4 files changed

+10
-10
lines changed

4 files changed

+10
-10
lines changed

postcss-scoped.cjs

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,21 @@
1+
/**
2+
* PostCSS plugin for rewriting some selectors in tailwindcss to prevent overspill of tailwind variables into the
3+
* surrounding application. There are more isolation mechanics in tailwind.config.js
4+
*/
5+
16
/**
27
* @type {import('postcss').PluginCreator}
38
*/
49
module.exports = (opts = {}) => ({
510
postcssPlugin: "postcss-scoped",
611
Once(root) {
712
root.walkRules((rule) => {
13+
// Rewrite global variable declaration to be only present on elements inside .rfs-root
814
if (rule.selector === "*, ::before, ::after") {
915
rule.selectors = rule.selectors.map((s) => (s === "*" ? "*:where(.rfs-root,.rfs-root *)" : ":where(.rfs-root,.rfs-root *)" + s))
1016
}
1117

18+
// Rewrite backdrop variable declaration to be only present on backdrops inside .rfs-root
1219
if (rule.selector === "::backdrop") {
1320
rule.selectors = rule.selectors.map((s) => ":where(.rfs-root,.rfs-root *)" + s)
1421
}

src/components/ui/dialog.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ const DialogOverlay = React.forwardRef<
2121
<DialogPrimitive.Overlay
2222
ref={ref}
2323
className={cn(
24-
"rfs-fixed rfs-inset-0 rfs-z-50 rfs-bg-black/80 rfs- data-[state=open]:rfs-animate-in data-[state=closed]:rfs-animate-out data-[state=closed]:rfs-fade-out-0 data-[state=open]:rfs-fade-in-0",
24+
"rfs-root rfs-fixed rfs-inset-0 rfs-z-50 rfs-bg-black/80 rfs- data-[state=open]:rfs-animate-in data-[state=closed]:rfs-animate-out data-[state=closed]:rfs-fade-out-0 data-[state=open]:rfs-fade-in-0",
2525
className
2626
)}
2727
{...props}

src/elastic-ui.css

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -11,13 +11,6 @@
1111
padding-top: 32px;
1212
}
1313

14-
/**
15-
* Body
16-
*/
17-
.sui-layout-body {
18-
background: hsl(var(--rfs-background));
19-
}
20-
2114
@media (max-width: 800px) {
2215
.sui-layout-body:after {
2316
display: none;

src/index.css

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,11 +69,11 @@
6969
}
7070

7171
@layer base {
72-
.sui-layout * {
72+
.rfs-root, .rfs-root * {
7373
border-color: hsl(var(--rfs-border));
7474
}
7575

76-
#storybook-root {
76+
.rfs-root {
7777
background-color: hsl(var(--rfs-background));
7878
color: hsl(var(--rfs-foreground));
7979
}

0 commit comments

Comments
 (0)