Skip to content

Commit 06b06b7

Browse files
committed
Remove LSHTable from the module.
- It hasn't been maintained as well as the other parts of the LSH package, and seems like a pretty clear case of feature creep. In any case, it's the type of functionality that should probably be implemented in its own module.
1 parent bfae18a commit 06b06b7

File tree

7 files changed

+1
-521
lines changed

7 files changed

+1
-521
lines changed

TODO.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,5 +11,3 @@
1111
- Add GPU support with `CuArrays.jl`.
1212

1313
### Old TODO items
14-
- ~Implement a `LSHTable` type. This will wrap around an `LSHFunction` and allow users to search for hash collisions.~ See [`6a9fc54`](https://github.com/wshand/LSH.jl/commit/6a9fc54b5ff5043467493cd9cdd5c140033b13a5).
15-
- ~Following the previous item, implement a `LSHTableCollection` (or similarly-named) type. `LSHTableCollection` will wrap around multiple `LSHTable`s. For a given query, if any one of the tables experiences a collision, then that collision will be added to the results.~ See [`5ef44a6`](https://github.com/wshand/LSH.jl/commit/5ef44a6b1955794e6cc602eb258b9bf297a82df5).

src/LSH.jl

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -33,14 +33,7 @@ include(joinpath("function_hashing", "chebhash.jl"))
3333
include(joinpath("function_hashing", "monte_carlo.jl"))
3434

3535
#========================
36-
Hash tables for LSHFunctions
37-
========================#
38-
39-
include(joinpath("tables", "table.jl"))
40-
include(joinpath("tables", "table_group.jl"))
41-
42-
#========================
43-
Hash tables for LSHFunctions
36+
Exports
4437
========================#
4538

4639
# Similarity functions, norms, inner products
@@ -57,7 +50,4 @@ export SimHash, L1Hash, L2Hash, MIPSHash, SignALSH, MinHash,
5750
export index_hash, query_hash, n_hashes, hashtype, similarity, lsh_family,
5851
embedded_similarity
5952

60-
# Hash tables and related functions
61-
export LSHTable, LSHTableGroup, insert!, reset!
62-
6353
end # module

src/tables/table.jl

Lines changed: 0 additions & 214 deletions
This file was deleted.

src/tables/table_group.jl

Lines changed: 0 additions & 43 deletions
This file was deleted.

test/runtests.jl

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,3 @@ include(joinpath("hashes", "test_lshfunction.jl"))
2828

2929
include(joinpath("function_hashing", "test_monte_carlo.jl"))
3030
include(joinpath("function_hashing", "test_chebhash.jl"))
31-
32-
include(joinpath("tables", "test_table.jl"))
33-
include(joinpath("tables", "test_table_group.jl"))

0 commit comments

Comments
 (0)