Skip to content

Commit f0e12c6

Browse files
committed
DOC: Amend CONTRIBUTING and ISSUE_TEMPLATE
1 parent 420232f commit f0e12c6

File tree

4 files changed

+61
-12
lines changed

4 files changed

+61
-12
lines changed

.github/ISSUE_TEMPLATE/1-bug.yml

+18-3
Original file line numberDiff line numberDiff line change
@@ -6,16 +6,30 @@ body:
66
attributes:
77
value: |
88
Thanks for putting in the effort to submit this bug report! Note, the
9-
best bug reports are accompanied with fixing patches / pull-requests.
9+
best bug reports are accompanied with fixing patches / pull-requests. 🙏
1010
1111
- type: checkboxes
1212
attributes:
1313
label: Contributing guidelines
1414
description: |
15-
I have read and will follow
15+
Please kindly follow this project's
1616
[Contributing Guidelines](https://github.com/kernc/backtesting.py/blob/master/CONTRIBUTING.md).
17+
The guidelines contain short technical notes on how to best contribute to this project.
1718
options:
18-
- label: I agree to follow this project's Contributing Guidelines
19+
- label: |
20+
I agree to follow this project's
21+
[Contributing Guidelines](https://github.com/kernc/backtesting.py/blob/master/CONTRIBUTING.md)
22+
which, I understand, contain short technical notes on how to best contribute to this project.
23+
required: true
24+
25+
- type: checkboxes
26+
attributes:
27+
label: Own due diligence
28+
options:
29+
- label: |
30+
I verify my due dilligence—I have went through the **tutorials** and the **API docs** and
31+
have used the **search** on **Issues** and GitHub **Disucussions**, as well all Google,
32+
with all the relevant search keywords.
1933
required: true
2034
2135
- type: textarea
@@ -67,6 +81,7 @@ body:
6781
1. Do ...
6882
2. ...
6983
3. Boom.
84+
4. See attached screenshots where I highlight the relevant parts.
7085
7186
- type: textarea
7287
id: versions

.github/ISSUE_TEMPLATE/2-enh.yml

+16-2
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,24 @@ body:
1212
attributes:
1313
label: Contributing guidelines
1414
description: |
15-
I have read and will follow
15+
Please kindly follow this project's
1616
[Contributing Guidelines](https://github.com/kernc/backtesting.py/blob/master/CONTRIBUTING.md).
17+
The guidelines contain short technical notes on how to best contribute to this project.
1718
options:
18-
- label: I agree to follow this project's Contributing Guidelines
19+
- label: |
20+
I agree to follow this project's
21+
[Contributing Guidelines](https://github.com/kernc/backtesting.py/blob/master/CONTRIBUTING.md)
22+
which, I understand, contain short technical notes on how to best contribute to this project.
23+
required: true
24+
25+
- type: checkboxes
26+
attributes:
27+
label: Own due diligence
28+
options:
29+
- label: |
30+
I verify my due dilligence—I have went through the **tutorials** and the **API docs** and
31+
have used the **search** on **Issues** and GitHub **Disucussions**, as well all Google,
32+
with all the relevant search keywords.
1933
required: true
2034
2135
- type: textarea

CONTRIBUTING.md

+24-7
Original file line numberDiff line numberDiff line change
@@ -13,22 +13,36 @@ reproducible manner. Review [how to report bugs effectively][bugs]
1313
and, particularly, how to
1414
[craft useful bug reports][bugs2] in Python.
1515

16-
In case of bugs, please submit full tracebacks
17-
18-
Wrap verbatim example code/traceback in [fenced code blocks],
19-
and use the preview function!
16+
In case of bugs, please submit **full** tracebacks.
17+
18+
Remember that GitHub Issues supports [markdown] syntax, so
19+
please **wrap verbatim example code**/traceback in
20+
triple-backtick-[fenced code blocks],
21+
such as:
22+
~~~markdown
23+
```python
24+
def foo():
25+
...
26+
```
27+
~~~
28+
and use the post preview function before posting!
2029

2130
Many thanks from the maintainers!
2231

32+
Note, In most cases, the issues are most readily dealt with when
33+
accompanied by [respective fixes/PRs].
34+
2335
[minimal working example]: https://en.wikipedia.org/wiki/Minimal_working_example
2436
[bugs]: https://www.chiark.greenend.org.uk/~sgtatham/bugs.html
2537
[bugs2]: https://matthewrocklin.com/blog/work/2018/02/28/minimal-bug-reports
38+
[markdown]: https://www.markdownguide.org/cheat-sheet/
2639
[fenced code blocks]: https://www.markdownguide.org/extended-syntax/#syntax-highlighting
40+
[respective fixes/PRs]: https://github.com/kernc/backtesting.py/blob/master/CONTRIBUTING.md#pull-requests
2741

2842

2943
Installation
3044
------------
31-
To install a developmental version of the project,
45+
To install a _developmental_ version of the project,
3246
first [fork the project]. Then:
3347

3448
git clone git@github.com:YOUR_USERNAME/backtesting.py
@@ -48,14 +62,14 @@ Before submitting a PR, ensure the tests pass:
4862

4963
Also ensure that idiomatic code style is respected by running:
5064

51-
flake8
65+
flake8 backtesting
5266
mypy backtesting
5367

5468

5569
Documentation
5670
-------------
5771
See _doc/README.md_. Besides Jupyter Notebook examples, all documentation
58-
is generated from [pdoc]-compatible docstrings in code.
72+
is generated from [pdoc]-compatible markdown docstrings in code.
5973

6074
[pdoc]: https://pdoc3.github.io/pdoc
6175

@@ -67,5 +81,8 @@ A general recommended reading:
6781
Please use explicit commit messages. See [NumPy's development workflow]
6882
for inspiration.
6983

84+
Please help review [existing PRs] you wish to see included.
85+
7086
[code-review]: https://mtlynch.io/code-review-love/
7187
[NumPy's development workflow]: https://numpy.org/doc/stable/dev/development_workflow.html
88+
[existing PRs]: https://github.com/kernc/backtesting.py/pulls

backtesting/__init__.py

+3
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,9 @@
88
99
## Tutorials
1010
11+
The tutorials encompass most framework features, so it's important
12+
and advisable to go through all of them. They are short.
13+
1114
* [Library of Utilities and Composable Base Strategies](../examples/Strategies Library.html)
1215
* [Multiple Time Frames](../examples/Multiple Time Frames.html)
1316
* [**Parameter Heatmap & Optimization**](../examples/Parameter Heatmap & Optimization.html)

0 commit comments

Comments
 (0)