Merge pull request #46 from kenzo0107/go_version_up_to_1_19_1

Go バージョンアップ 1.19.1

Author: kenzo0107

.github/workflows/lint.yml

@@ -13,14 +13,13 @@ jobs:
   lint:
     strategy:
       matrix:
-        go-version: [1.17.x]
+        go-version: [1.19.x]
         os: [ubuntu-latest]
     name: lint
     runs-on: ${{ matrix.os }}
     steps:
-      - uses: actions/checkout@v2
-      - name: golangci-lint
-        uses: golangci/golangci-lint-action@v2
+      - uses: actions/checkout@v3
+      - uses: actions/setup-go@v3
         with:
-          # Required: the version of golangci-lint is required and must be specified without patch version: we always use the latest patch version.
-          version: v1.29
+          go-version: ${{ matrix.go-version }}
+      - run: make lint

.github/workflows/test.yml

@@ -13,20 +13,17 @@ jobs:
   test:
     strategy:
       matrix:
-        go-version: [1.17.x]
+        go-version: [1.19.x]
         platform: [ubuntu-latest]
     runs-on: ${{ matrix.platform }}
     steps:
-      - name: Install Go
-        uses: actions/setup-go@v1
+      - uses: actions/setup-go@v3
         with:
           go-version: ${{ matrix.go-version }}
-      - name: Checkout code
-        uses: actions/checkout@v1
-      - name: Test
-        run: go test -v -count=1 -race -cover -coverprofile=coverage ./...
+      - uses: actions/checkout@v3
+      - run: go test -v -count=1 -race -cover -coverprofile=coverage ./...
       - name: Upload coverage to Codecov
-        uses: codecov/codecov-action@v1
+        uses: codecov/codecov-action@v3
         with:
           token: ${{ secrets.CODECOV_TOKEN }}
           file: ./coverage

.go-version

@@ -1,18 +1,14 @@
 linters:
   enable:
     - goimports
-    - golint
+    - revive
     - gosec
 
 linters-settings:
   errcheck:
     # report about not checking of errors in type assertions: `a := b.(MyStruct)`;
     # default is false: such cases aren't reported by default.
     check-type-assertions: true
-  golint:
-    # minimal confidence for issues, default is 0.8
-    # 小さいほど厳しくチェックする
-    min-confidence: 0.3
   govet:
     # report about shadowed variables
     check-shadowing: true
@@ -24,4 +20,8 @@ issues:
         - staticcheck
       # NOTE: TestMain での os.Exit 呼び出しは Go 1.15 で不要
       # see: https://golang.org/doc/go1.15#testing
-      text: "SA3000:"
+      text: 'SA3000:'
+    - linters:
+        - revive
+      # NOTE: パッケージコメントを適宜追加するのは開発効率が悪くなるという判断よりコメントは不要
+      text: 'package-comments: should have a package comment'

.golangci.yml

@@ -0,0 +1 @@
+golang 1.19.1

.tool-versions

@@ -34,7 +34,7 @@ cov:
 
 ## Install linter tool
 install_linter:
-	go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.43.0
+	go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.49.0
 .PHONY: install_linter
 
 ## Lint

Makefile

@@ -1,6 +1,6 @@
 module github.com/kenzo0107/backlog
 
-go 1.17
+go 1.19
 
 require (
 	github.com/google/go-querystring v1.1.0

go.mod

@@ -1,8 +1,7 @@
 github.com/davecgh/go-spew v1.1.0 h1:ZDRjVQ15GmhC3fiQ8ni8+OwkZQO4DARzQgrnXU1Liz8=
 github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
+github.com/google/go-cmp v0.5.2 h1:X2ev0eStA3AbceY54o37/0PQ/UWqKEiiO2dKL5OPaFM=
 github.com/google/go-cmp v0.5.2/go.mod h1:v8dTdLbMG2kIc/vJvl+f65V22dbkXbowE6jgT/gNBxE=
-github.com/google/go-querystring v1.0.0 h1:Xkwi/a1rcvNg1PPYe5vI8GbeBY/jrVuDX5ASuANWTrk=
-github.com/google/go-querystring v1.0.0/go.mod h1:odCYkC5MyYFN7vkCjXpyrEuKhc/BUO6wN/zVPAxq5ck=
 github.com/google/go-querystring v1.1.0 h1:AnCroh3fv4ZBgVIf1Iwtovgjaw/GiKJo8M8yD/fhyJ8=
 github.com/google/go-querystring v1.1.0/go.mod h1:Kcdr2DB4koayq7X8pmAG4sNG59So17icRSOU623lUBU=
 github.com/kylelemons/godebug v1.1.0 h1:RPNrshWIDI6G2gRW9EHilWtl7Z6Sb1BR0xunSBf0SNc=

go.sum

@@ -199,19 +199,21 @@ type Issues []*struct {
 // GetUserMySelfRecentrlyViewedIssues returns the list of issues a user view recently
 // This api returns a json below:
 // [
-// 		{
-//         "issue":{
-// 				"id":1111111,
-// 				...
-// 			}
-// 		},
-// 		{
-//         "issue":{
-// 				"id":2222222,
-// 				...
-// 			}
-// 		}
-// 		...
+//
+//			{
+//	        "issue":{
+//					"id":1111111,
+//					...
+//				}
+//			},
+//			{
+//	        "issue":{
+//					"id":2222222,
+//					...
+//				}
+//			}
+//			...
+//
 // ]
 func (c *Client) GetUserMySelfRecentrlyViewedIssues(opts *GetUserMySelfRecentrlyViewedIssuesOptions) (Issues, error) {
 	return c.GetUserMySelfRecentrlyViewedIssuesContext(context.Background(), opts)

issue.go

@@ -13,7 +13,7 @@ import (
 	"github.com/kylelemons/godebug/pretty"
 )
 
-var testJSONSharedFile string = fmt.Sprintf(`{
+var testJSONSharedFile = fmt.Sprintf(`{
 	"id": 454403,
 	"type": "file",
 	"dir": "/ユーザアイコン/",
@@ -25,7 +25,7 @@ var testJSONSharedFile string = fmt.Sprintf(`{
 	"updated": "2006-01-02T15:04:05Z"
 }`, testJSONUser, testJSONUser)
 
-var testJSONIssue string = fmt.Sprintf(`{
+var testJSONIssue = fmt.Sprintf(`{
 	"id": 1,
 	"projectId": 1,
 	"issueKey": "BLG-1",
@@ -105,15 +105,15 @@ var testJSONIssue string = fmt.Sprintf(`{
 	]
 }`, testJSONUser, testJSONUser, testJSONUser, testJSONSharedFile, testJSONUser)
 
-var testJSONNotification string = fmt.Sprintf(`{
+var testJSONNotification = fmt.Sprintf(`{
 	"id":22,
 	"alreadyRead":false,
 	"reason":2,
 	"user": %s,
 	"resourceAlreadyRead":false
 }`, testJSONUser)
 
-var testJSONIssueComment string = fmt.Sprintf(`{
+var testJSONIssueComment = fmt.Sprintf(`{
     "id": 6586,
     "content": "テスト",
     "changeLog": null,
@@ -124,7 +124,7 @@ var testJSONIssueComment string = fmt.Sprintf(`{
     "notifications": [%s]
 }`, testJSONUser, testJSONNotification)
 
-var testJSONAttachment string = fmt.Sprintf(`{
+var testJSONAttachment = fmt.Sprintf(`{
 	"id": 1,
 	"name": "Duke.png",
 	"size": 196186,

issue_test.go

@@ -3,7 +3,7 @@ package backlog
 import (
 	"bytes"
 	"fmt"
-	"io/ioutil"
+	"io"
 	"log"
 	"net/http"
 	"reflect"
@@ -108,7 +108,7 @@ func TestGetSpaceFailed(t *testing.T) {
 type mockHTTPClient struct{}
 
 func (m *mockHTTPClient) Do(*http.Request) (*http.Response, error) {
-	return &http.Response{StatusCode: 200, Body: ioutil.NopCloser(bytes.NewBufferString(`OK`))}, nil
+	return &http.Response{StatusCode: 200, Body: io.NopCloser(bytes.NewBufferString(`OK`))}, nil
 }
 
 func TestGetSpaceIcon(t *testing.T) {

space_test.go

@@ -5,7 +5,7 @@ import (
 	"time"
 )
 
-var referenceTime time.Time = time.Date(2006, time.January, 02, 15, 04, 05, 0, time.UTC)
+var referenceTime = time.Date(2006, time.January, 02, 15, 04, 05, 0, time.UTC)
 
 func TestTimestamp_String(t *testing.T) {
 	tests := []struct {

time_test.go

@@ -11,7 +11,7 @@ import (
 	"github.com/pkg/errors"
 )
 
-var testJSONUserWatching string = fmt.Sprintf(`{
+var testJSONUserWatching = fmt.Sprintf(`{
 	"id": 1,
 	"resourceAlreadyRead": true,
 	"note": "This is a note for the watching issue.",

watching_test.go

@@ -57,7 +57,7 @@ const testJSONWiki string = `{
 	"updated": "2006-01-02T15:04:05Z"
 }`
 
-var testJSONRecentlyViewedWiki string = fmt.Sprintf(`{
+var testJSONRecentlyViewedWiki = fmt.Sprintf(`{
     "page": %s,
     "updated": "2006-01-02T15:04:05Z"
 }`, testJSONWiki)