provide done callback

[ezekielchentnik]

can we add a node style done callback?

I was thinking of something like this:

 nodeRev({
  files: './build/public/bundle.css,./build/public/bundle.js',
  outputDir: './build/public/',
  file: './build/manifest.json',
  hash: true
}, (err, result) => {
  if(err){ 
    // handle
  }
  console.log(result)
})

then we can promisify it

const _nodeRev = require('node-rev').default

const promisify = (ctx, func = ctx) => (...args) => {
  return new Promise((resolve, reject) => {
    func.apply(ctx, [...args, (err, result) => err ? reject(err) : resolve(result)])
  })
}

const nodeRev = promisify(_nodeRev)

const rev = () => nodeRev({
  files: './build/public/bundle.css,./build/public/bundle.js',
  outputDir: './build/public/',
  file: './build/assets.json',
  hash: true
})

rev().then((manifest) => console.log(manifest))

[kellyrmilligan]

we can! that totally makes sense, just wasn't using it that way at the time I made this. I guess the question is, when you call the node api now it writes the manifest for you. are you wanting it to keep doing that, or if you use the callback then don't write it to the filesystem and leave it up to whoever is using it that way?

[kellyrmilligan]

i'll totally add the babel plugin for the exports stuff so we don't have to do .default as well, ugh forgot about that.

[kellyrmilligan]

i'm thinking if a person is using the node api, then they should use the manifest however they want and it won't write the file?

[ezekielchentnik]

@kellyrmilligan apologies for late reply. I agree, if you provide a callback it makes sense to prevent file write and let the consumer do what they want. That way they can decide what to do with the file (write, inject into next build step, keep in memory, write async, etc.)

[ezekielchentnik]

@kellyrmilligan if you don't mind I'd like to take a stab at a PR for this?!

[ezekielchentnik]

@kellyrmilligan +1 for babel, .default. FYI, in my example, i stole it from a build process where I don't have the luxury of transpile

[kellyrmilligan]

Go for it!