Skip to content

Commit 9b27e0e

Browse files
author
Vitalii Samolovskikh
committed
Merge branch 'master' into mongodb
2 parents 7599932 + 93b2477 commit 9b27e0e

File tree

2 files changed

+35
-32
lines changed

2 files changed

+35
-32
lines changed

grails-app/controllers/sample/AsynchronousMailController.groovy

Lines changed: 33 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package sample
22

3+
34
import grails.plugin.asyncmail.AsynchronousMailMessage
45
import grails.plugin.asyncmail.MessageStatus
56

@@ -9,13 +10,13 @@ class AsynchronousMailController {
910
static allowedMethods = [update: 'POST']
1011

1112
/**
12-
* Show all message in table.
13+
* List messages.
1314
*/
1415
def list() {
1516
params.max = Math.min(params.max ? params.max.toInteger() : 10, 100)
1617
params.sort = params.sort ?: 'createDate'
1718
params.order = params.order ?: 'desc'
18-
[list: AsynchronousMailMessage.list(params), total: AsynchronousMailMessage.count()]
19+
[resultList: AsynchronousMailMessage.list(params)]
1920
}
2021

2122
private withMessage(Closure cl) {
@@ -24,7 +25,7 @@ class AsynchronousMailController {
2425
return cl(message)
2526
}
2627

27-
flash.message = "Message with id ${params.id} not found."
28+
flash.message = "The message ${params.id} was not found."
2829
flash.error = true
2930
redirect(action: 'list')
3031
}
@@ -33,42 +34,42 @@ class AsynchronousMailController {
3334
* Show message data.
3435
*/
3536
def show() {
36-
withMessage { AsynchronousMailMessage message ->
37+
withMessage {AsynchronousMailMessage message ->
3738
return [message: message]
3839
}
3940
}
4041

4142
/**
42-
* Show form for editing.
43+
* Edit message data.
4344
*/
4445
def edit() {
45-
withMessage { AsynchronousMailMessage message ->
46+
withMessage {AsynchronousMailMessage message ->
4647
return [message: message]
4748
}
4849
}
4950

5051
/**
51-
* Update message
52+
* Update message.
5253
*/
5354
def update() {
54-
withMessage { AsynchronousMailMessage message ->
55+
withMessage {AsynchronousMailMessage message ->
5556
bindData(
5657
message, params,
5758
[include:
58-
[
59-
'status',
60-
'beginDate',
61-
'endDate',
62-
'maxAttemptsCount',
63-
'attemptInterval',
64-
'priority',
65-
'markDelete'
66-
]
59+
[
60+
'status',
61+
'beginDate',
62+
'endDate',
63+
'maxAttemptsCount',
64+
'attemptInterval',
65+
'priority',
66+
'markDelete'
67+
]
6768
]
6869
)
6970
message.attemptsCount = 0
70-
if (!message.hasErrors() && message.save()) {
71-
flash.message = "Message ${params.id} was updated."
71+
if (!message.hasErrors() && message.save(flush: true)) {
72+
flash.message = "The message ${params.id} was updated."
7273
redirect(action: 'show', id: message.id)
7374
} else {
7475
render(view: 'edit', model: [message: message])
@@ -77,37 +78,39 @@ class AsynchronousMailController {
7778
}
7879

7980
/**
80-
* Abort message sent
81+
* Abort message sending.
8182
*/
8283
def abort() {
83-
withMessage { AsynchronousMailMessage message ->
84+
withMessage {AsynchronousMailMessage message ->
8485
if (message.abortable) {
8586
message.status = MessageStatus.ABORT
86-
if (message.save()) {
87-
flash.message = "Message ${message.id} was aborted."
87+
if (message.save(flush: true)) {
88+
flash.message = "The message ${message.id} was aborted."
8889
} else {
89-
flash.message = "Can't abort message with id ${message.id}."
90+
flash.message = "Can't abort the message ${message.id}."
9091
flash.error = true
9192
}
9293
} else {
93-
flash.message = "Can't abort message with id ${message.id} and status ${message.status}."
94+
flash.message = "Can't abort the message ${message.id} with the status ${message.status}."
9495
flash.error = true
9596
}
9697
redirect(action: 'list')
9798
}
9899
}
99100

100101
/**
101-
* Delete message
102+
* Delete message.
102103
*/
103104
def delete() {
104-
withMessage { AsynchronousMailMessage message ->
105+
withMessage {AsynchronousMailMessage message ->
105106
try {
106-
message.delete()
107-
flash.message = "Message with id ${message.id} was deleted."
107+
message.delete(flush: true)
108+
flash.message = "The message ${message.id} was deleted."
108109
redirect(action: 'list')
109110
} catch (Exception e) {
110-
flash.message = "Can't delete message with id ${message.id}."
111+
def errorMessage = "Can't delete the message with the id ${message.id}.";
112+
log.error(errorMessage, e)
113+
flash.message = errorMessage
111114
flash.error = true
112115
redirect(action: 'show', id: message.id)
113116
}

grails-app/views/asynchronousMail/list.gsp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
</tr>
3434
</thead>
3535
<tbody>
36-
<g:each in="${list}" status="i" var="message">
36+
<g:each in="${resultList}" status="i" var="message">
3737
<tr class="${(i % 2) == 0 ? 'odd' : 'even'}">
3838
<td class="id">${message.id}</td>
3939
<td><g:link action="show" id="${message.id}">${fieldValue(bean: message, field: 'subject')}</g:link></td>
@@ -56,7 +56,7 @@
5656
</table>
5757

5858
<div class="paginate">
59-
<g:paginate total="${total}"/>
59+
<g:paginate total="${resultList.totalCount}"/>
6060
</div>
6161
</div>
6262
</body>

0 commit comments

Comments
 (0)