Skip to content

Commit ff8af8f

Browse files
fdmananakdave
authored andcommitted
btrfs: add details to error messages at btrfs_delete_delayed_dir_index()
Update the error messages with: 1) Fix typo in the first one, deltiona -> deletion; 2) Remove redundant part of the first message, the part following the comma, and including all the useful information: root, inode, index and error value; 3) Update the second message to use more formal language (example 'error' instead of 'err'), , remove redundant part about "deletion tree of delayed node..." and print the relevant information in the same format and order as the first message, without the ugly opening parenthesis without a space separating from the previous word. This also makes the message similar in format to the one we have at btrfs_insert_delayed_dir_index(). Reviewed-by: Boris Burkov <boris@bur.io> Signed-off-by: Filipe Manana <fdmanana@suse.com> Signed-off-by: David Sterba <dsterba@suse.com>
1 parent 5c365c8 commit ff8af8f

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

fs/btrfs/delayed-inode.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1618,7 +1618,8 @@ int btrfs_delete_delayed_dir_index(struct btrfs_trans_handle *trans,
16181618
*/
16191619
if (ret < 0) {
16201620
btrfs_err(trans->fs_info,
1621-
"metadata reservation failed for delayed dir item deltiona, should have been reserved");
1621+
"metadata reservation failed for delayed dir item deletion, index: %llu, root: %llu, inode: %llu, error: %d",
1622+
index, btrfs_root_id(node->root), node->inode_id, ret);
16221623
btrfs_release_delayed_item(item);
16231624
goto end;
16241625
}
@@ -1627,9 +1628,8 @@ int btrfs_delete_delayed_dir_index(struct btrfs_trans_handle *trans,
16271628
ret = __btrfs_add_delayed_item(node, item);
16281629
if (unlikely(ret)) {
16291630
btrfs_err(trans->fs_info,
1630-
"err add delayed dir index item(index: %llu) into the deletion tree of the delayed node(root id: %llu, inode id: %llu, errno: %d)",
1631-
index, btrfs_root_id(node->root),
1632-
node->inode_id, ret);
1631+
"failed to add delayed dir index item, root: %llu, inode: %llu, index: %llu, error: %d",
1632+
index, btrfs_root_id(node->root), node->inode_id, ret);
16331633
btrfs_delayed_item_release_metadata(dir->root, item);
16341634
btrfs_release_delayed_item(item);
16351635
}

0 commit comments

Comments
 (0)