Skip to content

Commit fb98bd0

Browse files
alessandro-g89broonie
authored andcommitted
spi: spi-sun4i: fix early activation
The SPI interface is activated before the CPOL setting is applied. In that moment, the clock idles high and CS goes low. After a short delay, CPOL and other settings are applied, which may cause the clock to change state and idle low. This transition is not part of a clock cycle, and it can confuse the receiving device. To prevent this unexpected transition, activate the interface while CPOL and the other settings are being applied. Signed-off-by: Alessandro Grassi <alessandro.grassi@mailbox.org> Link: https://patch.msgid.link/20250502095520.13825-1-alessandro.grassi@mailbox.org Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent e979a7c commit fb98bd0

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

drivers/spi/spi-sun4i.c

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -264,6 +264,9 @@ static int sun4i_spi_transfer_one(struct spi_controller *host,
264264
else
265265
reg |= SUN4I_CTL_DHB;
266266

267+
/* Now that the settings are correct, enable the interface */
268+
reg |= SUN4I_CTL_ENABLE;
269+
267270
sun4i_spi_write(sspi, SUN4I_CTL_REG, reg);
268271

269272
/* Ensure that we have a parent clock fast enough */
@@ -404,7 +407,7 @@ static int sun4i_spi_runtime_resume(struct device *dev)
404407
}
405408

406409
sun4i_spi_write(sspi, SUN4I_CTL_REG,
407-
SUN4I_CTL_ENABLE | SUN4I_CTL_MASTER | SUN4I_CTL_TP);
410+
SUN4I_CTL_MASTER | SUN4I_CTL_TP);
408411

409412
return 0;
410413

0 commit comments

Comments
 (0)