Skip to content

Commit f12b54d

Browse files
author
Marc Zyngier
committed
KVM: arm64: Repaint pmcr_n into nr_pmu_counters
The pmcr_n field obviously refers to PMCR_EL0.N, but is generally used as the number of counters seen by the guest. Rename it accordingly. Suggested-by: Oliver upton <oliver.upton@linux.dev> Signed-off-by: Marc Zyngier <maz@kernel.org>
1 parent 0af2f6b commit f12b54d

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

arch/arm64/include/asm/kvm_host.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -359,8 +359,8 @@ struct kvm_arch {
359359

360360
cpumask_var_t supported_cpus;
361361

362-
/* PMCR_EL0.N value for the guest */
363-
u8 pmcr_n;
362+
/* Maximum number of counters for the guest */
363+
u8 nr_pmu_counters;
364364

365365
/* Iterator for idreg debugfs */
366366
u8 idreg_debugfs_iter;

arch/arm64/kvm/pmu-emul.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -280,7 +280,7 @@ static u64 kvm_pmu_hyp_counter_mask(struct kvm_vcpu *vcpu)
280280
return 0;
281281

282282
hpmn = SYS_FIELD_GET(MDCR_EL2, HPMN, __vcpu_sys_reg(vcpu, MDCR_EL2));
283-
n = vcpu->kvm->arch.pmcr_n;
283+
n = vcpu->kvm->arch.nr_pmu_counters;
284284

285285
/*
286286
* Programming HPMN to a value greater than PMCR_EL0.N is
@@ -1032,7 +1032,7 @@ static void kvm_arm_set_pmu(struct kvm *kvm, struct arm_pmu *arm_pmu)
10321032
lockdep_assert_held(&kvm->arch.config_lock);
10331033

10341034
kvm->arch.arm_pmu = arm_pmu;
1035-
kvm->arch.pmcr_n = kvm_arm_pmu_get_max_counters(kvm);
1035+
kvm->arch.nr_pmu_counters = kvm_arm_pmu_get_max_counters(kvm);
10361036
}
10371037

10381038
/**
@@ -1261,7 +1261,7 @@ u64 kvm_vcpu_read_pmcr(struct kvm_vcpu *vcpu)
12611261
{
12621262
u64 pmcr = __vcpu_sys_reg(vcpu, PMCR_EL0);
12631263

1264-
return u64_replace_bits(pmcr, vcpu->kvm->arch.pmcr_n, ARMV8_PMU_PMCR_N);
1264+
return u64_replace_bits(pmcr, vcpu->kvm->arch.nr_pmu_counters, ARMV8_PMU_PMCR_N);
12651265
}
12661266

12671267
void kvm_pmu_nested_transition(struct kvm_vcpu *vcpu)

arch/arm64/kvm/sys_regs.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -785,7 +785,7 @@ static unsigned int pmu_visibility(const struct kvm_vcpu *vcpu,
785785
static u64 reset_pmu_reg(struct kvm_vcpu *vcpu, const struct sys_reg_desc *r)
786786
{
787787
u64 mask = BIT(ARMV8_PMU_CYCLE_IDX);
788-
u8 n = vcpu->kvm->arch.pmcr_n;
788+
u8 n = vcpu->kvm->arch.nr_pmu_counters;
789789

790790
if (n)
791791
mask |= GENMASK(n - 1, 0);
@@ -1217,7 +1217,7 @@ static int set_pmcr(struct kvm_vcpu *vcpu, const struct sys_reg_desc *r,
12171217
*/
12181218
if (!kvm_vm_has_ran_once(kvm) &&
12191219
new_n <= kvm_arm_pmu_get_max_counters(kvm))
1220-
kvm->arch.pmcr_n = new_n;
1220+
kvm->arch.nr_pmu_counters = new_n;
12211221

12221222
mutex_unlock(&kvm->arch.config_lock);
12231223

0 commit comments

Comments
 (0)