Skip to content

Commit dc924c2

Browse files
cristiccbebarino
authored andcommitted
soc: mediatek: pwrap: Switch to devm_clk_bulk_get_all_enabled()
The helper devm_clk_bulk_get_all_enable() missed to return the number of clocks stored in the clk_bulk_data table referenced by the clks argument and, therefore, will be dropped. Use the newly introduced devm_clk_bulk_get_all_enabled() variant instead, which is consistent with devm_clk_bulk_get_all() in terms of the returned value: > 0 if one or more clocks have been stored = 0 if there are no clocks < 0 if an error occurred Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com> Link: https://lore.kernel.org/r/20241217-clk_bulk_ena_fix-v5-1-aafbbb245155@collabora.com Acked-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Signed-off-by: Stephen Boyd <sboyd@kernel.org>
1 parent 7c4b497 commit dc924c2

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/soc/mediatek/mtk-pmic-wrap.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2518,8 +2518,8 @@ static int pwrap_probe(struct platform_device *pdev)
25182518
}
25192519
}
25202520

2521-
ret = devm_clk_bulk_get_all_enable(wrp->dev, &clk);
2522-
if (ret)
2521+
ret = devm_clk_bulk_get_all_enabled(wrp->dev, &clk);
2522+
if (ret < 0)
25232523
return dev_err_probe(wrp->dev, ret,
25242524
"failed to get clocks\n");
25252525

0 commit comments

Comments
 (0)