Skip to content

Commit cccf6ee

Browse files
Xiaofei Tanrafaeljw
authored andcommitted
ACPI: HED: Always initialize before evged
When the HED driver is built-in, it initializes after evged because they both are at the same initcall level, so the initialization ordering depends on the Makefile order. However, this prevents RAS records coming in between the evged driver initialization and the HED driver initialization from being handled. If the number of such RAS records is above the APEI HEST error source number, the HEST resources may be exhausted, and that may affect subsequent RAS error reporting. To fix this issue, change the initcall level of HED to subsys_initcall and prevent the driver from being built as a module by changing ACPI_HED in Kconfig from "tristate" to "bool". Signed-off-by: Xiaofei Tan <tanxiaofei@huawei.com> Link: https://patch.msgid.link/20250212063408.927666-1-tanxiaofei@huawei.com [ rjw: Changelog edits ] Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
1 parent 0ad2507 commit cccf6ee

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

drivers/acpi/Kconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -452,7 +452,7 @@ config ACPI_SBS
452452
the modules will be called sbs and sbshc.
453453

454454
config ACPI_HED
455-
tristate "Hardware Error Device"
455+
bool "Hardware Error Device"
456456
help
457457
This driver supports the Hardware Error Device (PNP0C33),
458458
which is used to report some hardware errors notified via

drivers/acpi/hed.c

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,12 @@ static struct acpi_driver acpi_hed_driver = {
8080
.remove = acpi_hed_remove,
8181
},
8282
};
83-
module_acpi_driver(acpi_hed_driver);
83+
84+
static int __init acpi_hed_driver_init(void)
85+
{
86+
return acpi_bus_register_driver(&acpi_hed_driver);
87+
}
88+
subsys_initcall(acpi_hed_driver_init);
8489

8590
MODULE_AUTHOR("Huang Ying");
8691
MODULE_DESCRIPTION("ACPI Hardware Error Device Driver");

0 commit comments

Comments
 (0)