Skip to content

Commit bd7d536

Browse files
yanzhao56bonzini
authored andcommitted
KVM: x86: Introduce supported_quirks to block disabling quirks
Introduce supported_quirks in kvm_caps to store platform-specific force-enabled quirks. No functional changes intended. Signed-off-by: Yan Zhao <yan.y.zhao@intel.com> Message-ID: <20250224070832.31394-1-yan.y.zhao@intel.com> [Remove unsupported quirks at KVM_ENABLE_CAP time. - Paolo] Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
1 parent a4dae7c commit bd7d536

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

arch/x86/kvm/x86.c

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4790,7 +4790,7 @@ int kvm_vm_ioctl_check_extension(struct kvm *kvm, long ext)
47904790
r = enable_pmu ? KVM_CAP_PMU_VALID_MASK : 0;
47914791
break;
47924792
case KVM_CAP_DISABLE_QUIRKS2:
4793-
r = KVM_X86_VALID_QUIRKS;
4793+
r = kvm_caps.supported_quirks;
47944794
break;
47954795
case KVM_CAP_X86_NOTIFY_VMEXIT:
47964796
r = kvm_caps.has_notify_vmexit;
@@ -6529,11 +6529,11 @@ int kvm_vm_ioctl_enable_cap(struct kvm *kvm,
65296529
switch (cap->cap) {
65306530
case KVM_CAP_DISABLE_QUIRKS2:
65316531
r = -EINVAL;
6532-
if (cap->args[0] & ~KVM_X86_VALID_QUIRKS)
6532+
if (cap->args[0] & ~kvm_caps.supported_quirks)
65336533
break;
65346534
fallthrough;
65356535
case KVM_CAP_DISABLE_QUIRKS:
6536-
kvm->arch.disabled_quirks |= cap->args[0];
6536+
kvm->arch.disabled_quirks |= cap->args[0] & kvm_caps.supported_quirks;
65376537
r = 0;
65386538
break;
65396539
case KVM_CAP_SPLIT_IRQCHIP: {
@@ -9783,6 +9783,7 @@ int kvm_x86_vendor_init(struct kvm_x86_init_ops *ops)
97839783
kvm_host.xcr0 = xgetbv(XCR_XFEATURE_ENABLED_MASK);
97849784
kvm_caps.supported_xcr0 = kvm_host.xcr0 & KVM_SUPPORTED_XCR0;
97859785
}
9786+
kvm_caps.supported_quirks = KVM_X86_VALID_QUIRKS;
97869787
kvm_caps.inapplicable_quirks = KVM_X86_CONDITIONAL_QUIRKS;
97879788

97889789
rdmsrl_safe(MSR_EFER, &kvm_host.efer);
@@ -12734,7 +12735,7 @@ int kvm_arch_init_vm(struct kvm *kvm, unsigned long type)
1273412735
/* Decided by the vendor code for other VM types. */
1273512736
kvm->arch.pre_fault_allowed =
1273612737
type == KVM_X86_DEFAULT_VM || type == KVM_X86_SW_PROTECTED_VM;
12737-
kvm->arch.disabled_quirks = kvm_caps.inapplicable_quirks;
12738+
kvm->arch.disabled_quirks = kvm_caps.inapplicable_quirks & kvm_caps.supported_quirks;
1273812739

1273912740
ret = kvm_page_track_init(kvm);
1274012741
if (ret)

arch/x86/kvm/x86.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,8 @@ struct kvm_caps {
3434
u64 supported_xcr0;
3535
u64 supported_xss;
3636
u64 supported_perf_cap;
37+
38+
u64 supported_quirks;
3739
u64 inapplicable_quirks;
3840
};
3941

0 commit comments

Comments
 (0)