Skip to content

Commit b0c3f5d

Browse files
committed
KVM: selftests: Macrofy vm_get_stat() to auto-generate stat name string
Turn vm_get_stat() into a macro that generates a string for the stat name, as opposed to taking a string. This will allow hardening stat usage in the future to generate errors on unknown stats at compile time. No functional change intended. Link: https://lore.kernel.org/r/20250111005049.1247555-5-seanjc@google.com Signed-off-by: Sean Christopherson <seanjc@google.com>
1 parent eead13d commit b0c3f5d

File tree

3 files changed

+12
-12
lines changed

3 files changed

+12
-12
lines changed

tools/testing/selftests/kvm/include/kvm_util.h

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -534,13 +534,13 @@ void read_stat_data(int stats_fd, struct kvm_stats_header *header,
534534
void __vm_get_stat(struct kvm_vm *vm, const char *stat_name, uint64_t *data,
535535
size_t max_elements);
536536

537-
static inline uint64_t vm_get_stat(struct kvm_vm *vm, const char *stat_name)
538-
{
539-
uint64_t data;
540-
541-
__vm_get_stat(vm, stat_name, &data, 1);
542-
return data;
543-
}
537+
#define vm_get_stat(vm, stat) \
538+
({ \
539+
uint64_t data; \
540+
\
541+
__vm_get_stat(vm, #stat, &data, 1); \
542+
data; \
543+
})
544544

545545
void vm_create_irqchip(struct kvm_vm *vm);
546546

tools/testing/selftests/kvm/x86/dirty_log_page_splitting_test.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,9 +41,9 @@ struct kvm_page_stats {
4141

4242
static void get_page_stats(struct kvm_vm *vm, struct kvm_page_stats *stats, const char *stage)
4343
{
44-
stats->pages_4k = vm_get_stat(vm, "pages_4k");
45-
stats->pages_2m = vm_get_stat(vm, "pages_2m");
46-
stats->pages_1g = vm_get_stat(vm, "pages_1g");
44+
stats->pages_4k = vm_get_stat(vm, pages_4k);
45+
stats->pages_2m = vm_get_stat(vm, pages_2m);
46+
stats->pages_1g = vm_get_stat(vm, pages_1g);
4747
stats->hugepages = stats->pages_2m + stats->pages_1g;
4848

4949
pr_debug("\nPage stats after %s: 4K: %ld 2M: %ld 1G: %ld huge: %ld\n",

tools/testing/selftests/kvm/x86/nx_huge_pages_test.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ static void check_2m_page_count(struct kvm_vm *vm, int expected_pages_2m)
7373
{
7474
int actual_pages_2m;
7575

76-
actual_pages_2m = vm_get_stat(vm, "pages_2m");
76+
actual_pages_2m = vm_get_stat(vm, pages_2m);
7777

7878
TEST_ASSERT(actual_pages_2m == expected_pages_2m,
7979
"Unexpected 2m page count. Expected %d, got %d",
@@ -84,7 +84,7 @@ static void check_split_count(struct kvm_vm *vm, int expected_splits)
8484
{
8585
int actual_splits;
8686

87-
actual_splits = vm_get_stat(vm, "nx_lpage_splits");
87+
actual_splits = vm_get_stat(vm, nx_lpage_splits);
8888

8989
TEST_ASSERT(actual_splits == expected_splits,
9090
"Unexpected NX huge page split count. Expected %d, got %d",

0 commit comments

Comments
 (0)