Skip to content

Commit a8972d5

Browse files
hvilleneuvedoosuperna9999
authored andcommitted
drm: panel: jd9365da-h3: fix reset signal polarity
In jadard_prepare() a reset pulse is generated with the following statements (delays ommited for clarity): gpiod_set_value(jadard->reset, 1); --> Deassert reset gpiod_set_value(jadard->reset, 0); --> Assert reset for 10ms gpiod_set_value(jadard->reset, 1); --> Deassert reset However, specifying second argument of "0" to gpiod_set_value() means to deassert the GPIO, and "1" means to assert it. If the reset signal is defined as GPIO_ACTIVE_LOW in the DTS, the above statements will incorrectly generate the reset pulse (inverted) and leave it asserted (LOW) at the end of jadard_prepare(). Fix reset behavior by inverting gpiod_set_value() second argument in jadard_prepare(). Also modify second argument to devm_gpiod_get() in jadard_dsi_probe() to assert the reset when probing. Do not modify it in jadard_unprepare() as it is already properly asserted with "1", which seems to be the intended behavior. Fixes: 6b818c5 ("drm: panel: Add Jadard JD9365DA-H3 DSI panel") Cc: stable@vger.kernel.org Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com> Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Link: https://lore.kernel.org/r/20240927135306.857617-1-hugo@hugovil.com Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> Link: https://patchwork.freedesktop.org/patch/msgid/20240927135306.857617-1-hugo@hugovil.com
1 parent e00a2e5 commit a8972d5

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -109,13 +109,13 @@ static int jadard_prepare(struct drm_panel *panel)
109109
if (jadard->desc->lp11_to_reset_delay_ms)
110110
msleep(jadard->desc->lp11_to_reset_delay_ms);
111111

112-
gpiod_set_value(jadard->reset, 1);
112+
gpiod_set_value(jadard->reset, 0);
113113
msleep(5);
114114

115-
gpiod_set_value(jadard->reset, 0);
115+
gpiod_set_value(jadard->reset, 1);
116116
msleep(10);
117117

118-
gpiod_set_value(jadard->reset, 1);
118+
gpiod_set_value(jadard->reset, 0);
119119
msleep(130);
120120

121121
ret = jadard->desc->init(jadard);
@@ -1130,7 +1130,7 @@ static int jadard_dsi_probe(struct mipi_dsi_device *dsi)
11301130
dsi->format = desc->format;
11311131
dsi->lanes = desc->lanes;
11321132

1133-
jadard->reset = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW);
1133+
jadard->reset = devm_gpiod_get(dev, "reset", GPIOD_OUT_HIGH);
11341134
if (IS_ERR(jadard->reset)) {
11351135
DRM_DEV_ERROR(&dsi->dev, "failed to get our reset GPIO\n");
11361136
return PTR_ERR(jadard->reset);

0 commit comments

Comments
 (0)