Skip to content

Commit 9a5cd59

Browse files
Friday Yangbebarino
authored andcommitted
dt-bindings: clock: mediatek: Add SMI LARBs reset for MT8188
On the MediaTek platform, some SMI LARBs are directly connected to the SMI Common, while others are connected to the SMI Sub-Common, which in turn is connected to the SMI Common. The hardware block diagram can be described as follows. SMI-Common(Smart Multimedia Interface Common) | +----------------+------------------+ | | | | | | | | | | | | | | | larb0 SMI-Sub-Common0 SMI-Sub-Common1 | | | | | larb1 larb2 larb3 larb7 larb9 For previous discussion on the direction of the code modifications, please refer to: https://lore.kernel.org/all/CAFGrd9qZhObQXvm2_abqaX83xMLqxjQETB2= wXpobDWU1CnvkA@mail.gmail.com/ https://lore.kernel.org/all/CAPDyKFpokXV2gJDgowbixTvOH_5VL3B5H8ey hP+KJ5Fasm2rFg@mail.gmail.com/ On the MediaTek MT8188 SoC platform, we encountered power-off failures and SMI bus hang issues during camera stress tests. The issue arises because bus glitches are sometimes produced when MTCMOS powers on or off. While this is fairly normal, the software must handle these glitches to avoid mistaking them for transaction signals. What's more, this issue emerged only after the initial upstreaming of this binding. Without these patches, the SMI becomes unstable during camera stress tests. The software solutions can be summarized as follows: 1. Use CLAMP to disable the SMI sub-common port after turning off the LARB CG and before turning off the LARB MTCMOS. 2. Use CLAMP to disable/enable the SMI sub-common port. 3. Implement an AXI reset for SMI LARBs. This patch add '#reset-cells' for the clock controller located in image, camera and IPE subsystems. Signed-off-by: Friday Yang <friday.yang@mediatek.com> Link: https://lore.kernel.org/r/20250221075058.14180-2-friday.yang@mediatek.com Acked-by: Conor Dooley <conor.dooley@microchip.com> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Signed-off-by: Stephen Boyd <sboyd@kernel.org>
1 parent 0dc1161 commit 9a5cd59

File tree

1 file changed

+21
-0
lines changed

1 file changed

+21
-0
lines changed

Documentation/devicetree/bindings/clock/mediatek,mt8188-clock.yaml

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,27 @@ required:
5757
- reg
5858
- '#clock-cells'
5959

60+
allOf:
61+
- if:
62+
properties:
63+
compatible:
64+
contains:
65+
enum:
66+
- mediatek,mt8188-camsys-rawa
67+
- mediatek,mt8188-camsys-rawb
68+
- mediatek,mt8188-camsys-yuva
69+
- mediatek,mt8188-camsys-yuvb
70+
- mediatek,mt8188-imgsys-wpe1
71+
- mediatek,mt8188-imgsys-wpe2
72+
- mediatek,mt8188-imgsys-wpe3
73+
- mediatek,mt8188-imgsys1-dip-nr
74+
- mediatek,mt8188-imgsys1-dip-top
75+
- mediatek,mt8188-ipesys
76+
77+
then:
78+
required:
79+
- '#reset-cells'
80+
6081
additionalProperties: false
6182

6283
examples:

0 commit comments

Comments
 (0)