Skip to content

Commit 999595a

Browse files
jtlaytonchucklever
authored andcommitted
nfsd: handle NFS4ERR_BADSLOT on CB_SEQUENCE better
Currently it just restarts the call, without getting a new slot. Signed-off-by: Jeff Layton <jlayton@kernel.org> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
1 parent bf36c14 commit 999595a

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

fs/nfsd/nfs4callback.c

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1389,6 +1389,13 @@ static bool nfsd4_cb_sequence_done(struct rpc_task *task, struct nfsd4_callback
13891389
rpc_delay(task, 2 * HZ);
13901390
return false;
13911391
case -NFS4ERR_BADSLOT:
1392+
/*
1393+
* BADSLOT means that the client and server are out of sync
1394+
* as to the backchannel parameters. Mark the backchannel faulty
1395+
* and restart the RPC, but leak the slot so no one uses it.
1396+
*/
1397+
nfsd4_mark_cb_fault(cb->cb_clp);
1398+
cb->cb_held_slot = -1;
13921399
goto retry_nowait;
13931400
case -NFS4ERR_SEQ_MISORDERED:
13941401
if (session->se_cb_seq_nr[cb->cb_held_slot] != 1) {

0 commit comments

Comments
 (0)