Skip to content

Commit 92c749e

Browse files
rhythm16Marc Zyngier
authored andcommitted
KVM: arm64: nv: Remove clearing of ICH_LR<n>.EOI if ICH_LR<n>.HW == 1
In the case of ICH_LR<n>.HW == 1, bit 41 of LR is just a part of pINTID without EOI meaning, and bit 41 will be zeroed by the subsequent clearing of ICH_LR_PHYS_ID_MASK anyway. No functional changes intended. Signed-off-by: Wei-Lin Chang <r09922117@csie.ntu.edu.tw> Link: https://lore.kernel.org/r/20250512133223.866999-1-r09922117@csie.ntu.edu.tw Signed-off-by: Marc Zyngier <maz@kernel.org>
1 parent 00b0300 commit 92c749e

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

arch/arm64/kvm/vgic/vgic-v3-nested.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -240,9 +240,6 @@ static void vgic_v3_create_shadow_lr(struct kvm_vcpu *vcpu,
240240
goto next;
241241
}
242242

243-
/* It is illegal to have the EOI bit set with HW */
244-
lr &= ~ICH_LR_EOI;
245-
246243
/* Translate the virtual mapping to the real one */
247244
lr &= ~ICH_LR_PHYS_ID_MASK;
248245
lr |= FIELD_PREP(ICH_LR_PHYS_ID_MASK, (u64)irq->hwintid);

0 commit comments

Comments
 (0)