Skip to content

Commit 43fa890

Browse files
jtlaytonchucklever
authored andcommitted
nfsd: always release slot when requeueing callback
If the callback is going to be requeued to the workqueue, then release the slot. The callback client and session could change and the slot may no longer be valid after that point. Signed-off-by: Jeff Layton <jlayton@kernel.org> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
1 parent 6c1cefb commit 43fa890

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

fs/nfsd/nfs4callback.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1405,6 +1405,7 @@ static bool nfsd4_cb_sequence_done(struct rpc_task *task, struct nfsd4_callback
14051405
rpc_restart_call_prepare(task);
14061406
goto out;
14071407
requeue:
1408+
nfsd41_cb_release_slot(cb);
14081409
nfsd4_requeue_cb(task, cb);
14091410
return false;
14101411
}

0 commit comments

Comments
 (0)