Skip to content

Commit 21f4314

Browse files
leitaobroonie
authored andcommitted
spi: tegra210-quad: add rate limiting and simplify timeout error message
On malfunctioning hardware, timeout error messages can appear thousands of times, creating unnecessary system pressure and log bloat. This patch makes two improvements: 1. Replace dev_err() with dev_err_ratelimited() to prevent log flooding when hardware errors persist 2. Remove the redundant timeout value parameter from the error message, as 'ret' is always zero in this error path These changes reduce logging overhead while maintaining necessary error reporting for debugging purposes. Signed-off-by: Breno Leitao <leitao@debian.org> Link: https://patch.msgid.link/20250401-tegra-v2-2-126c293ec047@debian.org Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent 41c721f commit 21f4314

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/spi/spi-tegra210-quad.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1118,8 +1118,8 @@ static int tegra_qspi_combined_seq_xfer(struct tegra_qspi *tqspi,
11181118
QSPI_DMA_TIMEOUT);
11191119

11201120
if (WARN_ON_ONCE(ret == 0)) {
1121-
dev_err(tqspi->dev, "QSPI Transfer failed with timeout: %d\n",
1122-
ret);
1121+
dev_err_ratelimited(tqspi->dev,
1122+
"QSPI Transfer failed with timeout\n");
11231123
if (tqspi->is_curr_dma_xfer &&
11241124
(tqspi->cur_direction & DATA_DIR_TX))
11251125
dmaengine_terminate_all

0 commit comments

Comments
 (0)