Skip to content

Commit 1fe4a44

Browse files
Jethro DonaldsonSteve French
authored andcommitted
smb: client: fix memory leak during error handling for POSIX mkdir
The response buffer for the CREATE request handled by smb311_posix_mkdir() is leaked on the error path (goto err_free_rsp_buf) because the structure pointer *rsp passed to free_rsp_buf() is not assigned until *after* the error condition is checked. As *rsp is initialised to NULL, free_rsp_buf() becomes a no-op and the leak is instead reported by __kmem_cache_shutdown() upon subsequent rmmod of cifs.ko if (and only if) the error path has been hit. Pass rsp_iov.iov_base to free_rsp_buf() instead, similar to the code in other functions in smb2pdu.c for which *rsp is assigned late. Cc: stable@vger.kernel.org Signed-off-by: Jethro Donaldson <devel@jro.nz> Signed-off-by: Steve French <stfrench@microsoft.com>
1 parent 82f2b0b commit 1fe4a44

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

fs/smb/client/smb2pdu.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2968,7 +2968,7 @@ int smb311_posix_mkdir(const unsigned int xid, struct inode *inode,
29682968
/* Eventually save off posix specific response info and timestamps */
29692969

29702970
err_free_rsp_buf:
2971-
free_rsp_buf(resp_buftype, rsp);
2971+
free_rsp_buf(resp_buftype, rsp_iov.iov_base);
29722972
kfree(pc_buf);
29732973
err_free_req:
29742974
cifs_small_buf_release(req);

0 commit comments

Comments
 (0)