Skip to content

Commit 12a0fd2

Browse files
committed
clk: Print an error when clk registration fails
We have a lot of driver code that prints an error message when registering a clk fails. Do that in the core function instead to consolidate code. This also helps drivers avoid the anti-pattern of accessing the struct clk_hw::init pointer after registration. Signed-off-by: Stephen Boyd <sboyd@kernel.org> Link: https://lore.kernel.org/r/20250226235408.1339266-1-sboyd@kernel.org
1 parent a112395 commit 12a0fd2

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

drivers/clk/clk.c

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4397,6 +4397,13 @@ __clk_register(struct device *dev, struct device_node *np, struct clk_hw *hw)
43974397
fail_name:
43984398
kref_put(&core->ref, __clk_release);
43994399
fail_out:
4400+
if (dev) {
4401+
dev_err_probe(dev, ret, "failed to register clk '%s' (%pS)\n",
4402+
init->name, hw);
4403+
} else {
4404+
pr_err("%pOF: error %pe: failed to register clk '%s' (%pS)\n",
4405+
np, ERR_PTR(ret), init->name, hw);
4406+
}
44004407
return ERR_PTR(ret);
44014408
}
44024409

0 commit comments

Comments
 (0)