Skip to content

Commit 0eb802b

Browse files
vdonnefortMarc Zyngier
authored andcommitted
KVM: arm64: Add a range to __pkvm_host_wrprotect_guest()
In preparation for supporting stage-2 huge mappings for np-guest. Add a nr_pages argument to the __pkvm_host_wrprotect_guest hypercall. This range supports only two values: 1 or PMD_SIZE / PAGE_SIZE (that is 512 on a 4K-pages system). Signed-off-by: Vincent Donnefort <vdonnefort@google.com> Link: https://lore.kernel.org/r/20250521124834.1070650-6-vdonnefort@google.com Signed-off-by: Marc Zyngier <maz@kernel.org>
1 parent f28f1d0 commit 0eb802b

File tree

4 files changed

+17
-12
lines changed

4 files changed

+17
-12
lines changed

arch/arm64/kvm/hyp/include/nvhe/mem_protect.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,8 @@ int __pkvm_host_share_guest(u64 pfn, u64 gfn, u64 nr_pages, struct pkvm_hyp_vcpu
4343
enum kvm_pgtable_prot prot);
4444
int __pkvm_host_unshare_guest(u64 gfn, u64 nr_pages, struct pkvm_hyp_vm *hyp_vm);
4545
int __pkvm_host_relax_perms_guest(u64 gfn, struct pkvm_hyp_vcpu *vcpu, enum kvm_pgtable_prot prot);
46-
int __pkvm_host_wrprotect_guest(u64 gfn, struct pkvm_hyp_vm *hyp_vm);
4746
int __pkvm_host_test_clear_young_guest(u64 gfn, bool mkold, struct pkvm_hyp_vm *vm);
47+
int __pkvm_host_wrprotect_guest(u64 gfn, u64 nr_pages, struct pkvm_hyp_vm *hyp_vm);
4848
int __pkvm_host_mkyoung_guest(u64 gfn, struct pkvm_hyp_vcpu *vcpu);
4949

5050
bool addr_is_memory(phys_addr_t phys);

arch/arm64/kvm/hyp/nvhe/hyp-main.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -310,6 +310,7 @@ static void handle___pkvm_host_wrprotect_guest(struct kvm_cpu_context *host_ctxt
310310
{
311311
DECLARE_REG(pkvm_handle_t, handle, host_ctxt, 1);
312312
DECLARE_REG(u64, gfn, host_ctxt, 2);
313+
DECLARE_REG(u64, nr_pages, host_ctxt, 3);
313314
struct pkvm_hyp_vm *hyp_vm;
314315
int ret = -EINVAL;
315316

@@ -320,7 +321,7 @@ static void handle___pkvm_host_wrprotect_guest(struct kvm_cpu_context *host_ctxt
320321
if (!hyp_vm)
321322
goto out;
322323

323-
ret = __pkvm_host_wrprotect_guest(gfn, hyp_vm);
324+
ret = __pkvm_host_wrprotect_guest(gfn, nr_pages, hyp_vm);
324325
put_pkvm_hyp_vm(hyp_vm);
325326
out:
326327
cpu_reg(host_ctxt, 1) = ret;

arch/arm64/kvm/hyp/nvhe/mem_protect.c

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1052,7 +1052,7 @@ int __pkvm_host_unshare_guest(u64 gfn, u64 nr_pages, struct pkvm_hyp_vm *vm)
10521052
return ret;
10531053
}
10541054

1055-
static void assert_host_shared_guest(struct pkvm_hyp_vm *vm, u64 ipa)
1055+
static void assert_host_shared_guest(struct pkvm_hyp_vm *vm, u64 ipa, u64 size)
10561056
{
10571057
u64 phys;
10581058
int ret;
@@ -1063,7 +1063,7 @@ static void assert_host_shared_guest(struct pkvm_hyp_vm *vm, u64 ipa)
10631063
host_lock_component();
10641064
guest_lock_component(vm);
10651065

1066-
ret = __check_host_shared_guest(vm, &phys, ipa, PAGE_SIZE);
1066+
ret = __check_host_shared_guest(vm, &phys, ipa, size);
10671067

10681068
guest_unlock_component(vm);
10691069
host_unlock_component();
@@ -1083,25 +1083,29 @@ int __pkvm_host_relax_perms_guest(u64 gfn, struct pkvm_hyp_vcpu *vcpu, enum kvm_
10831083
if (prot & ~KVM_PGTABLE_PROT_RWX)
10841084
return -EINVAL;
10851085

1086-
assert_host_shared_guest(vm, ipa);
1086+
assert_host_shared_guest(vm, ipa, PAGE_SIZE);
10871087
guest_lock_component(vm);
10881088
ret = kvm_pgtable_stage2_relax_perms(&vm->pgt, ipa, prot, 0);
10891089
guest_unlock_component(vm);
10901090

10911091
return ret;
10921092
}
10931093

1094-
int __pkvm_host_wrprotect_guest(u64 gfn, struct pkvm_hyp_vm *vm)
1094+
int __pkvm_host_wrprotect_guest(u64 gfn, u64 nr_pages, struct pkvm_hyp_vm *vm)
10951095
{
1096-
u64 ipa = hyp_pfn_to_phys(gfn);
1096+
u64 size, ipa = hyp_pfn_to_phys(gfn);
10971097
int ret;
10981098

10991099
if (pkvm_hyp_vm_is_protected(vm))
11001100
return -EPERM;
11011101

1102-
assert_host_shared_guest(vm, ipa);
1102+
ret = __guest_check_transition_size(0, ipa, nr_pages, &size);
1103+
if (ret)
1104+
return ret;
1105+
1106+
assert_host_shared_guest(vm, ipa, size);
11031107
guest_lock_component(vm);
1104-
ret = kvm_pgtable_stage2_wrprotect(&vm->pgt, ipa, PAGE_SIZE);
1108+
ret = kvm_pgtable_stage2_wrprotect(&vm->pgt, ipa, size);
11051109
guest_unlock_component(vm);
11061110

11071111
return ret;
@@ -1115,7 +1119,7 @@ int __pkvm_host_test_clear_young_guest(u64 gfn, bool mkold, struct pkvm_hyp_vm *
11151119
if (pkvm_hyp_vm_is_protected(vm))
11161120
return -EPERM;
11171121

1118-
assert_host_shared_guest(vm, ipa);
1122+
assert_host_shared_guest(vm, ipa, PAGE_SIZE);
11191123
guest_lock_component(vm);
11201124
ret = kvm_pgtable_stage2_test_clear_young(&vm->pgt, ipa, PAGE_SIZE, mkold);
11211125
guest_unlock_component(vm);
@@ -1131,7 +1135,7 @@ int __pkvm_host_mkyoung_guest(u64 gfn, struct pkvm_hyp_vcpu *vcpu)
11311135
if (pkvm_hyp_vm_is_protected(vm))
11321136
return -EPERM;
11331137

1134-
assert_host_shared_guest(vm, ipa);
1138+
assert_host_shared_guest(vm, ipa, PAGE_SIZE);
11351139
guest_lock_component(vm);
11361140
kvm_pgtable_stage2_mkyoung(&vm->pgt, ipa, 0);
11371141
guest_unlock_component(vm);

arch/arm64/kvm/pkvm.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -409,7 +409,7 @@ int pkvm_pgtable_stage2_wrprotect(struct kvm_pgtable *pgt, u64 addr, u64 size)
409409

410410
lockdep_assert_held(&kvm->mmu_lock);
411411
for_each_mapping_in_range_safe(pgt, addr, addr + size, mapping) {
412-
ret = kvm_call_hyp_nvhe(__pkvm_host_wrprotect_guest, handle, mapping->gfn);
412+
ret = kvm_call_hyp_nvhe(__pkvm_host_wrprotect_guest, handle, mapping->gfn, 1);
413413
if (WARN_ON(ret))
414414
break;
415415
}

0 commit comments

Comments
 (0)