exit with error only when deps from *k8s.io/* have version mismatch

On-behalf-of: SAP robert.vasek@sap.com
Signed-off-by: Robert Vasek <robert.vasek@clyso.com>

Author: gman0

hack/verify-go-modules.sh

@@ -112,23 +112,18 @@ function diff_version_deps {
 function print_diff_version_deps {
   jq -r '
     to_entries
-      | map("Error: version mismatch: \(.key) is \(.value.has), but \(.value.wants) expected")
+      | map("Version mismatch: \(.key) is \(.value.has), but \(.value.wants) expected")
       | join("\n")
-      | halt_error(1)
     '
 }
 
 # Compares versions of dependencies in the supplied go.mod to
 # makes sure they are in line with the ones declared in
-# k8s.io/kubernetes module and prints the result.
-function compare_mod_versions_or_fail {
+# k8s.io/kubernetes module.
+function compare_mod_versions_with_k8s_deps {
   gomod_file="${1}"
-  echo "Verifying dependency versions in ${gomod_file} against ${k8s_gomod}"
   deps="$(list_deps ${gomod_file})"
-
-  diff_version_deps <(echo "${deps}") <(echo "${k8s_deps}") \
-    | print_diff_version_deps "${gomod_file}" 1>&2 \
-    || { echo ; exit 1 ; }
+  diff_version_deps <(echo "${deps}") <(echo "${k8s_deps}")
 }
 
 function gomod_filepath_for {
@@ -149,9 +144,17 @@ for dir in "${MODULE_DIRS[@]}"; do
       exit 1
     fi
 
-    compare_mod_versions_or_fail "${dir}/go.mod"
+    gomod_file="${dir}/go.mod"
+    echo "Verifying dependency versions in ${gomod_file} against ${k8s_gomod}"
+
+    diff="$(compare_mod_versions_with_k8s_deps ${dir}/go.mod)"
+    if [[ -n "${diff}" ]]; then
+      echo "${diff}" | print_diff_version_deps 1>&2
+      echo "${diff}" | grep -q "k8s.io/" && {
+        echo "Error: dependencies from '*k8s.io/*' must be in line with ${k8s_gomod}" 1>&2
+        exit 1
+      } || true
+      echo "Continuing because no fatal errors found"
+    fi
   )
 done
-
-compare_mod_versions_or_fail "$(gomod_filepath_for github.com/kcp-dev/client-go)"
-compare_mod_versions_or_fail "$(gomod_filepath_for github.com/kcp-dev/apimachinery/v2)"