Fix PHPStan errors up to level 5

Author: Jakob Linskeseder

.github/workflows/lint.yml

@@ -12,7 +12,7 @@ jobs:
     strategy:
             fail-fast: true
             matrix:
-                php: [7.4, 8.0]
+                php: ['7.4', '8.0']
 
     runs-on: ubuntu-latest
     name: PHP@${{ matrix.php }}
@@ -32,3 +32,6 @@ jobs:
 
     - name: Lint code
       run: composer run-script lint
+
+    - name: Analyse code
+      run: composer run-script analyse

.github/workflows/test.yml

@@ -13,7 +13,7 @@ jobs:
     strategy:
             fail-fast: true
             matrix:
-                php: [7.3, 7.4, 8.0]
+                php: ['7.3', '7.4', '8.0']
 
     runs-on: ubuntu-latest
     name: PHP@${{ matrix.php }}

composer.json

@@ -26,12 +26,14 @@
     },
     "require-dev": {
         "phpunit/phpunit": "^8.0 || ^9.0",
-        "friendsofphp/php-cs-fixer": "^2.16"
+        "friendsofphp/php-cs-fixer": "^2.16",
+        "phpstan/phpstan": "^1.2"
     },
     "scripts": {
         "test": "phpunit",
         "coverage": "phpunit --coverage-clover coverage.xml",
         "lint": "php-cs-fixer fix -v --dry-run",
-        "fix": "php-cs-fixer fix -v"
+        "fix": "php-cs-fixer fix -v",
+        "analyse": "phpstan analyse src --level 5"
     }
 }

src/Binding.php

@@ -10,12 +10,12 @@ abstract class Binding
     protected $property;
 
     /**
-     * @var string
+     * @var ?string
      */
     protected $jsonField;
 
     /**
-     * @var string
+     * @var ?string
      */
     protected $type;
 
@@ -27,10 +27,10 @@ abstract class Binding
     /**
      * FieldBinding constructor.
      *
-     * @param string $property   the property to bind to
-     * @param string $jsonField  the json field
-     * @param string $type       the desired type of the property
-     * @param bool   $isRequired defines if the field value is required during decoding
+     * @param string  $property   the property to bind to
+     * @param ?string $jsonField  the json field
+     * @param ?string $type       the desired type of the property
+     * @param bool    $isRequired defines if the field value is required during decoding
      */
     public function __construct($property, $jsonField, $type, $isRequired = false)
     {
@@ -42,8 +42,6 @@ public function __construct($property, $jsonField, $type, $isRequired = false)
 
     /**
      * validates the given binding data.
-     *
-     * @param mixed $jsonData
      */
     public function validate(array $jsonData): bool
     {
@@ -69,7 +67,7 @@ public function jsonField(): string
     /**
      * executes the defined binding method on the class instance.
      *
-     * @param mixed    $jsonData
+     * @param ?array   $jsonData
      * @param Property $property the class instance to bind to
      *
      * @return mixed

src/Bindings/CallbackBinding.php

@@ -16,9 +16,6 @@ class CallbackBinding extends Binding
 
     /**
      * CallbackBinding constructor.
-     *
-     * @param string $property
-     * @param Closure $callback
      */
     public function __construct(string $property, Closure $callback)
     {

src/JsonDecoder.php

@@ -103,8 +103,8 @@ function ($element) use ($classType) {
     /**
      * decodes the given array data into an instance of the given class type.
      *
-     * @param $jsonArrayData array
-     * @param $classType string
+     * @param array  $jsonArrayData
+     * @param string $classType
      *
      * @return mixed an instance of $classType
      */
@@ -207,7 +207,7 @@ private function parseJson(string $json, string $root = null)
      *
      * @return array the list of generated bindings
      *
-     * @throws ReflectionException
+     * @throws \ReflectionException
      */
     private function scan(string $class)
     {
@@ -243,6 +243,9 @@ private function scan(string $class)
     private function createTransformer(string $class, array $bindings): Transformer
     {
         return new class($class, $bindings) implements Transformer {
+            private $class;
+            private $bindings;
+
             public function __construct($class, $bindings)
             {
                 $this->class    = $class;

src/Property.php

@@ -18,7 +18,7 @@ class Property
     private $propertyName;
 
     /**
-     * @var ReflectionProperty
+     * @var ?ReflectionProperty
      */
     private $property;
 
@@ -28,7 +28,7 @@ class Property
      * @param mixed  $instance     the class instance the property lives in
      * @param string $propertyName the name of the property
      *
-     * @return static
+     * @return self
      */
     public static function create($instance, string $propertyName)
     {
@@ -39,7 +39,7 @@ public static function create($instance, string $propertyName)
         } catch (Exception $ignored) {
         }
 
-        return new static($instance, $propertyName, $property);
+        return new self($instance, $propertyName, $property);
     }
 
     private function __construct($instance, string $propertyName, ReflectionProperty $property = null)