Merge pull request #17 from karriereat/bugfix/transform-raw-private-properties

Transform private properties in transformRaw

Author: fetzi

src/JsonDecoder.php

@@ -2,6 +2,8 @@
 
 namespace Karriere\JsonDecoder;
 
+use Karriere\JsonDecoder\Bindings\RawBinding;
+
 class JsonDecoder
 {
     /**
@@ -97,12 +99,12 @@ protected function transformRaw($jsonArrayData, $instance)
             return null;
         }
 
-        foreach ($jsonArrayData as $key => $value) {
-            if (property_exists($instance, $key)) {
-                $instance->{$key} = $value;
-            }
+        $classBindings = new ClassBindings($this);
+
+        foreach (array_keys($jsonArrayData) as $property) {
+            $classBindings->register(new RawBinding($property));
         }
 
-        return $instance;
+        return $classBindings->decode($jsonArrayData, $instance);
     }
 }

tests/specs/JsonDecoderSpec.php

@@ -91,6 +91,18 @@ public function it_should_be_able_to_transform_an_array_of_objects()
         $response[1]->id->shouldBe(2);
         $response[1]->name->shouldBe('Jane');
     }
+
+    public function it_should_be_able_to_transform_raw_with_private_properties()
+    {
+        $this->beConstructedWith(true, false);
+        $jsonString = '{"id": 1, "name": "John Doe"}';
+
+        $response = $this->decode($jsonString, SampleWithPrivateProperties::class);
+
+        $response->shouldHaveType(SampleWithPrivateProperties::class);
+        $response->getId()->shouldBe(1);
+        $response->getName()->shouldReturn('John Doe');
+    }
 }
 
 class JsonDecoderSample
@@ -99,6 +111,22 @@ class JsonDecoderSample
     public $name;
 }
 
+class SampleWithPrivateProperties
+{
+    private $id;
+    private $name;
+
+    public function getId()
+    {
+        return $this->id;
+    }
+
+    public function getName()
+    {
+        return $this->name;
+    }
+}
+
 class SampleTransformer implements Transformer
 {
     public function register(ClassBindings $classBindings)