Merge pull request #46 from karriereat/feature/php8

fetzi · web-flow · commit 93b5ed6ae91c · 2021-11-02T07:51:48.000+01:00
Add support for PHP 8
diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
@@ -12,7 +12,7 @@ jobs:
     strategy:
             fail-fast: true
             matrix:
-                php: [7.4]
+                php: [7.4, 8.0]
 
     runs-on: ubuntu-latest
     name: PHP@${{ matrix.php }}
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -13,7 +13,7 @@ jobs:
     strategy:
             fail-fast: true
             matrix:
-                php: [7.3, 7.4]
+                php: [7.3, 7.4, 8.0]
 
     runs-on: ubuntu-latest
     name: PHP@${{ matrix.php }}
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [4.1.0] - 2021-10-20
+### Added
+- Support for PHP 8
+
 ## [4.0.3] - 2020-11-30
 ### Fixed
 - To strict param type in `transform` method
diff --git a/composer.json b/composer.json
@@ -21,7 +21,7 @@
         }
     },
     "require": {
-        "php": ">=7.3",
+        "php": "^7.3 | ^8.0",
         "php-di/phpdoc-reader": "^2.1"
     },
     "require-dev": {
diff --git a/tests/Bindings/AliasBindingTest.php b/tests/Bindings/AliasBindingTest.php
@@ -11,7 +11,7 @@
 class AliasBindingTest extends TestCase
 {
     /** @test */
-    public function it_aliases_a_field()
+    public function itAliasesAField()
     {
         $binding  = new AliasBinding('firstname', 'first-name');
         $person   = new Person();
@@ -23,7 +23,7 @@ public function it_aliases_a_field()
     }
 
     /** @test */
-    public function it_skips_a_not_available_field()
+    public function itSkipsANotAvailableField()
     {
         $binding  = new AliasBinding('lastname', 'lastname');
         $person   = new Person();
diff --git a/tests/Bindings/ArrayBindingTest.php b/tests/Bindings/ArrayBindingTest.php
@@ -12,7 +12,7 @@
 class ArrayBindingTest extends TestCase
 {
     /** @test */
-    public function it_binds_an_array()
+    public function itBindsAnArray()
     {
         $binding  = new ArrayBinding('address', 'addresses', Address::class);
         $person   = new Person();
@@ -42,7 +42,7 @@ public function it_binds_an_array()
     }
 
     /** @test */
-    public function it_skips_a_not_available_field()
+    public function itSkipsANotAvailableField()
     {
         $binding  = new ArrayBinding('address', 'addresses', Address::class);
         $person   = new Person();
diff --git a/tests/Bindings/CallbackBindingTest.php b/tests/Bindings/CallbackBindingTest.php
@@ -11,7 +11,7 @@
 class CallbackBindingTest extends TestCase
 {
     /** @test */
-    public function it_binds_with_a_callback()
+    public function itBindsWithACallback()
     {
         $binding = new CallbackBinding('firstname', function () {
             return 'Jane';
@@ -25,7 +25,7 @@ public function it_binds_with_a_callback()
     }
 
     /** @test */
-    public function it_always_validates_to_true()
+    public function itAlwaysValidatesToTrue()
     {
         $binding = new CallbackBinding('firstname', function () {
             return 'Jane';
diff --git a/tests/Bindings/DateTimeBindingTest.php b/tests/Bindings/DateTimeBindingTest.php
@@ -12,52 +12,52 @@
 class DateTimeBindingTest extends TestCase
 {
     /** @test */
-    public function it_validates_successfully()
+    public function itValidatesSuccessfully()
     {
         $binding = new DateTimeBinding('date', 'date');
 
         $this->assertTrue($binding->validate(['date' => '2020-01-01T12:00:00+00:00']));
     }
 
     /** @test */
-    public function it_fails_on_validation_of_a_required_property_with_an_invalid_date_format()
+    public function itFailsOnValidationOfARequiredPropertyWithAnInvalidDateFormat()
     {
         $binding = new DateTimeBinding('date', 'date', true);
 
         $this->assertFalse($binding->validate(['date' => 'invalid']));
     }
 
     /** @test */
-    public function it_fails_on_validation_of_a_not_required_property_with_an_invalid_date_format()
+    public function itFailsOnValidationOfANotRequiredPropertyWithAnInvalidDateFormat()
     {
         $binding = new DateTimeBinding('date', 'date', false);
 
         $this->assertFalse($binding->validate(['date' => 'invalid']));
     }
 
     /** @test */
-    public function it_fails_on_validation_for_a_not_set_field_that_is_required()
+    public function itFailsOnValidationForANotSetFieldThatIsRequired()
     {
         $binding = new DateTimeBinding('date', 'date', true);
         $this->assertFalse($binding->validate([]));
     }
 
     /** @test */
-    public function it_succeeds_on_validation_for_a_not_set_field_that_is_not_required()
+    public function itSucceedsOnValidationForANotSetFieldThatIsNotRequired()
     {
         $binding = new DateTimeBinding('date', 'date', false);
         $this->assertTrue($binding->validate([]));
     }
 
     /** @test */
-    public function it_succeeds_on_validation_for_an_empty_field_that_is_not_required()
+    public function itSucceedsOnValidationForAnEmptyFieldThatIsNotRequired()
     {
         $binding = new DateTimeBinding('date', 'date', false);
         $this->assertTrue($binding->validate(['date' => '']));
     }
 
     /** @test */
-    public function it_binds_an_atom_datetime()
+    public function itBindsAnAtomDatetime()
     {
         $binding  = new DateTimeBinding('date', 'date');
         $person   = new Person();
@@ -71,7 +71,7 @@ public function it_binds_an_atom_datetime()
     }
 
     /** @test */
-    public function it_ignores_an_empty_datetime_value()
+    public function itIgnoresAnEmptyDatetimeValue()
     {
         $binding  = new DateTimeBinding('date', 'date');
         $person   = new Person();
@@ -83,7 +83,7 @@ public function it_ignores_an_empty_datetime_value()
     }
 
     /** @test */
-    public function it_ignores_an_invalid_datetime_value()
+    public function itIgnoresAnInvalidDatetimeValue()
     {
         $binding  = new DateTimeBinding('date', 'date');
         $person   = new Person();
diff --git a/tests/Bindings/FieldBindingTest.php b/tests/Bindings/FieldBindingTest.php
@@ -12,7 +12,7 @@
 class FieldBindingTest extends TestCase
 {
     /** @test */
-    public function it_binds_a_field_to_a_class_instance()
+    public function itBindsAFieldToAClassInstance()
     {
         $binding  = new FieldBinding('address', 'address', Address::class);
         $person   = new Person();
@@ -27,7 +27,7 @@ public function it_binds_a_field_to_a_class_instance()
     }
 
     /** @test */
-    public function it_ignores_a_not_defined_field()
+    public function itIgnoresANotDefinedField()
     {
         $binding  = new FieldBinding('address', 'address', Address::class);
         $person   = new Person();
diff --git a/tests/Bindings/RawBindingTest.php b/tests/Bindings/RawBindingTest.php
@@ -11,7 +11,7 @@
 class RawBindingTest extends TestCase
 {
     /** @test */
-    public function it_sets_a_raw_value()
+    public function itSetsARawValue()
     {
         $binding  = new RawBinding('firstname');
         $person   = new Person();
@@ -23,7 +23,7 @@ public function it_sets_a_raw_value()
     }
 
     /** @test */
-    public function it_ignores_a_not_existing_property()
+    public function itIgnoresANotExistingProperty()
     {
         $binding  = new RawBinding('firstname');
         $person   = new Person();
@@ -35,7 +35,7 @@ public function it_ignores_a_not_existing_property()
     }
 
     /** @test */
-    public function it_always_validates_to_true()
+    public function itAlwaysValidatesToTrue()
     {
         $binding = new RawBinding('firstname');
 
diff --git a/tests/ClassBindingsTest.php b/tests/ClassBindingsTest.php
@@ -15,7 +15,7 @@
 class ClassBindingsTest extends TestCase
 {
     /** @test */
-    public function it_registers_a_binding()
+    public function itRegistersABinding()
     {
         $classBindings = new ClassBindings(new JsonDecoder());
 
@@ -27,7 +27,7 @@ public function it_registers_a_binding()
     }
 
     /** @test */
-    public function it_registers_a_callback_binding()
+    public function itRegistersACallbackBinding()
     {
         $classBindings = new ClassBindings(new JsonDecoder());
 
@@ -41,7 +41,7 @@ public function it_registers_a_callback_binding()
     }
 
     /** @test */
-    public function it_fails_to_register_a_not_compatible_binding_class()
+    public function itFailsToRegisterANotCompatibleBindingClass()
     {
         $classBindings = new ClassBindings(new JsonDecoder());
 
@@ -51,7 +51,7 @@ public function it_fails_to_register_a_not_compatible_binding_class()
     }
 
     /** @test */
-    public function it_throws_an_exception_if_binding_validation_fails()
+    public function itThrowsAnExceptionIfBindingValidationFails()
     {
         $classBindings = new ClassBindings(new JsonDecoder());
 
@@ -72,7 +72,7 @@ public function bind($jsonDecoder, $jsonData, $property)
     }
 
     /** @test */
-    public function it_executes_callback_bindings_when_property_name_is_contained_in_json_fields()
+    public function itExecutesCallbackBindingsWhenPropertyNameIsContainedInJsonFields()
     {
         $classBindings = new ClassBindings(new JsonDecoder());
         $classBindings->register(new CallbackBinding('firstname', function ($data) {
@@ -85,7 +85,7 @@ public function it_executes_callback_bindings_when_property_name_is_contained_in
     }
 
     /** @test */
-    public function it_executes_callback_bindings_when_property_name_is_not_contained_in_json_fields()
+    public function itExecutesCallbackBindingsWhenPropertyNameIsNotContainedInJsonFields()
     {
         $classBindings = new ClassBindings(new JsonDecoder());
         $classBindings->register(new CallbackBinding('somePropertyName', function () {
diff --git a/tests/JsonDecoderTest.php b/tests/JsonDecoderTest.php
@@ -19,7 +19,7 @@
 class JsonDecoderTest extends TestCase
 {
     /** @test */
-    public function it_fails_for_an_invalid_json_input()
+    public function itFailsForAnInvalidJsonInput()
     {
         $jsonDecoder = new JsonDecoder();
 
@@ -29,7 +29,7 @@ public function it_fails_for_an_invalid_json_input()
     }
 
     /** @test */
-    public function it_is_able_to_decode_json_without_a_transformer()
+    public function itIsAbleToDecodeJsonWithoutATransformer()
     {
         $jsonDecoder = new JsonDecoder();
 
@@ -44,7 +44,7 @@ public function it_is_able_to_decode_json_without_a_transformer()
     }
 
     /** @test */
-    public function it_is_able_to_decode_json_with_a_transformer()
+    public function itIsAbleToDecodeJsonWithATransformer()
     {
         $jsonDecoder = new JsonDecoder();
         $jsonDecoder->register(new class() implements Transformer {
@@ -74,7 +74,7 @@ public function transforms()
     }
 
     /** @test */
-    public function it_is_able_to_decode_json_with_a_more_complex_transformer()
+    public function itIsAbleToDecodeJsonWithAMoreComplexTransformer()
     {
         $jsonDecoder = new JsonDecoder();
         $jsonDecoder->register(new class() implements Transformer {
@@ -106,7 +106,7 @@ public function transforms()
     }
 
     /** @test */
-    public function it_decodes_multiple_instances_of_a_type()
+    public function itDecodesMultipleInstancesOfAType()
     {
         $jsonDecoder = new JsonDecoder();
         $persons     = $jsonDecoder->decodeMultiple(file_get_contents(__DIR__ . '/data/persons.json'), Person::class);
@@ -118,7 +118,7 @@ public function it_decodes_multiple_instances_of_a_type()
     }
 
     /** @test */
-    public function it_handles_empty_json_strings_gracefully()
+    public function itHandlesEmptyJsonStringsGracefully()
     {
         $jsonDecoder = new JsonDecoder();
 
@@ -145,7 +145,7 @@ public function transforms()
     }
 
     /** @test */
-    public function it_decodes_an_object_with_a_root_key()
+    public function itDecodesAnObjectWithARootKey()
     {
         $jsonDecoder = new JsonDecoder();
 
@@ -157,7 +157,7 @@ public function it_decodes_an_object_with_a_root_key()
     }
 
     /** @test */
-    public function it_decodes_multiple_objects_with_a_root_key()
+    public function itDecodesMultipleObjectsWithARootKey()
     {
         $jsonDecoder = new JsonDecoder();
 
@@ -171,7 +171,7 @@ public function it_decodes_multiple_objects_with_a_root_key()
     }
 
     /** @test */
-    public function it_fails_for_not_existing_root_key()
+    public function itFailsForNotExistingRootKey()
     {
         $this->expectException(NotExistingRootException::class);
 
@@ -180,7 +180,7 @@ public function it_fails_for_not_existing_root_key()
     }
 
     /** @test */
-    public function it_scans_a_class_and_generates_a_transformer()
+    public function itScansAClassAndGeneratesATransformer()
     {
         $jsonDecoder = new JsonDecoder();
         $jsonDecoder->scanAndRegister(Person::class);
@@ -199,7 +199,7 @@ public function it_scans_a_class_and_generates_a_transformer()
     }
 
     /** @test */
-    public function it_can_auto_case_from_snake_to_camel()
+    public function itCanAutoCaseFromSnakeToCamel()
     {
         $jsonDecoder = new JsonDecoder(true);
 
@@ -212,7 +212,7 @@ public function it_can_auto_case_from_snake_to_camel()
     }
 
     /** @test */
-    public function it_can_auto_case_from_kebap_to_camel()
+    public function itCanAutoCaseFromKebapToCamel()
     {
         $jsonDecoder = new JsonDecoder(true);
 
diff --git a/tests/PropertyTest.php b/tests/PropertyTest.php

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@`
`21`	`21`	`}`
`22`	`22`	`},`
`23`	`23`	`"require": {`
`24`		`- "php": ">=7.3",`
	`24`	`+ "php": "^7.3 \| ^8.0",`
`25`	`25`	`"php-di/phpdoc-reader": "^2.1"`
`26`	`26`	`},`
`27`	`27`	`"require-dev": {`
Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@`
`11`	`11`	`class AliasBindingTest extends TestCase`
`12`	`12`	`{`
`13`	`13`	`/** @test */`
`14`		`- public function it_aliases_a_field()`
	`14`	`+ public function itAliasesAField()`
`15`	`15`	`{`
`16`	`16`	`$binding = new AliasBinding('firstname', 'first-name');`
`17`	`17`	`$person = new Person();`
`@@ -23,7 +23,7 @@ public function it_aliases_a_field()`
`23`	`23`	`}`
`24`	`24`
`25`	`25`	`/** @test */`
`26`		`- public function it_skips_a_not_available_field()`
	`26`	`+ public function itSkipsANotAvailableField()`
`27`	`27`	`{`
`28`	`28`	`$binding = new AliasBinding('lastname', 'lastname');`
`29`	`29`	`$person = new Person();`
Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@`
`12`	`12`	`class ArrayBindingTest extends TestCase`
`13`	`13`	`{`
`14`	`14`	`/** @test */`
`15`		`- public function it_binds_an_array()`
	`15`	`+ public function itBindsAnArray()`
`16`	`16`	`{`
`17`	`17`	`$binding = new ArrayBinding('address', 'addresses', Address::class);`
`18`	`18`	`$person = new Person();`
`@@ -42,7 +42,7 @@ public function it_binds_an_array()`
`42`	`42`	`}`
`43`	`43`
`44`	`44`	`/** @test */`
`45`		`- public function it_skips_a_not_available_field()`
	`45`	`+ public function itSkipsANotAvailableField()`
`46`	`46`	`{`
`47`	`47`	`$binding = new ArrayBinding('address', 'addresses', Address::class);`
`48`	`48`	`$person = new Person();`
Original file line number	Diff line number	Diff line change
`@@ -12,52 +12,52 @@`
`12`	`12`	`class DateTimeBindingTest extends TestCase`
`13`	`13`	`{`
`14`	`14`	`/** @test */`
`15`		`- public function it_validates_successfully()`
	`15`	`+ public function itValidatesSuccessfully()`
`16`	`16`	`{`
`17`	`17`	`$binding = new DateTimeBinding('date', 'date');`
`18`	`18`
`19`	`19`	`$this->assertTrue($binding->validate(['date' => '2020-01-01T12:00:00+00:00']));`
`20`	`20`	`}`
`21`	`21`
`22`	`22`	`/** @test */`
`23`		`- public function it_fails_on_validation_of_a_required_property_with_an_invalid_date_format()`
	`23`	`+ public function itFailsOnValidationOfARequiredPropertyWithAnInvalidDateFormat()`
`24`	`24`	`{`
`25`	`25`	`$binding = new DateTimeBinding('date', 'date', true);`
`26`	`26`
`27`	`27`	`$this->assertFalse($binding->validate(['date' => 'invalid']));`
`28`	`28`	`}`
`29`	`29`
`30`	`30`	`/** @test */`
`31`		`- public function it_fails_on_validation_of_a_not_required_property_with_an_invalid_date_format()`
	`31`	`+ public function itFailsOnValidationOfANotRequiredPropertyWithAnInvalidDateFormat()`
`32`	`32`	`{`
`33`	`33`	`$binding = new DateTimeBinding('date', 'date', false);`
`34`	`34`
`35`	`35`	`$this->assertFalse($binding->validate(['date' => 'invalid']));`
`36`	`36`	`}`
`37`	`37`
`38`	`38`	`/** @test */`
`39`		`- public function it_fails_on_validation_for_a_not_set_field_that_is_required()`
	`39`	`+ public function itFailsOnValidationForANotSetFieldThatIsRequired()`
`40`	`40`	`{`
`41`	`41`	`$binding = new DateTimeBinding('date', 'date', true);`
`42`	`42`	`$this->assertFalse($binding->validate([]));`
`43`	`43`	`}`
`44`	`44`
`45`	`45`	`/** @test */`
`46`		`- public function it_succeeds_on_validation_for_a_not_set_field_that_is_not_required()`
	`46`	`+ public function itSucceedsOnValidationForANotSetFieldThatIsNotRequired()`
`47`	`47`	`{`
`48`	`48`	`$binding = new DateTimeBinding('date', 'date', false);`
`49`	`49`	`$this->assertTrue($binding->validate([]));`
`50`	`50`	`}`
`51`	`51`
`52`	`52`	`/** @test */`
`53`		`- public function it_succeeds_on_validation_for_an_empty_field_that_is_not_required()`
	`53`	`+ public function itSucceedsOnValidationForAnEmptyFieldThatIsNotRequired()`
`54`	`54`	`{`
`55`	`55`	`$binding = new DateTimeBinding('date', 'date', false);`
`56`	`56`	`$this->assertTrue($binding->validate(['date' => '']));`
`57`	`57`	`}`
`58`	`58`
`59`	`59`	`/** @test */`
`60`		`- public function it_binds_an_atom_datetime()`
	`60`	`+ public function itBindsAnAtomDatetime()`
`61`	`61`	`{`
`62`	`62`	`$binding = new DateTimeBinding('date', 'date');`
`63`	`63`	`$person = new Person();`
`@@ -71,7 +71,7 @@ public function it_binds_an_atom_datetime()`
`71`	`71`	`}`
`72`	`72`
`73`	`73`	`/** @test */`
`74`		`- public function it_ignores_an_empty_datetime_value()`
	`74`	`+ public function itIgnoresAnEmptyDatetimeValue()`
`75`	`75`	`{`
`76`	`76`	`$binding = new DateTimeBinding('date', 'date');`
`77`	`77`	`$person = new Person();`
`@@ -83,7 +83,7 @@ public function it_ignores_an_empty_datetime_value()`
`83`	`83`	`}`
`84`	`84`
`85`	`85`	`/** @test */`
`86`		`- public function it_ignores_an_invalid_datetime_value()`
	`86`	`+ public function itIgnoresAnInvalidDatetimeValue()`
`87`	`87`	`{`
`88`	`88`	`$binding = new DateTimeBinding('date', 'date');`
`89`	`89`	`$person = new Person();`