Skip to content

Commit 20a707c

Browse files
authored
Fix bogus case/when syntax. Levels 1, 2, and 6 previously defaulted to UNKNOWN. (#441)
1 parent 34b5150 commit 20a707c

File tree

2 files changed

+17
-2
lines changed

2 files changed

+17
-2
lines changed

lib/rdkafka/bindings.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -124,13 +124,13 @@ class TopicPartitionList < FFI::Struct
124124
:void, [:pointer, :int, :string, :string]
125125
) do |_client_ptr, level, _level_string, line|
126126
severity = case level
127-
when 0 || 1 || 2
127+
when 0, 1, 2
128128
Logger::FATAL
129129
when 3
130130
Logger::ERROR
131131
when 4
132132
Logger::WARN
133-
when 5 || 6
133+
when 5, 6
134134
Logger::INFO
135135
when 7
136136
Logger::DEBUG

spec/rdkafka/bindings_spec.rb

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,16 @@
3636
expect(log_queue).to have_received(:<<).with([Logger::FATAL, "rdkafka: log line"])
3737
end
3838

39+
it "should log fatal messages" do
40+
Rdkafka::Bindings::LogCallback.call(nil, 1, nil, "log line")
41+
expect(log_queue).to have_received(:<<).with([Logger::FATAL, "rdkafka: log line"])
42+
end
43+
44+
it "should log fatal messages" do
45+
Rdkafka::Bindings::LogCallback.call(nil, 2, nil, "log line")
46+
expect(log_queue).to have_received(:<<).with([Logger::FATAL, "rdkafka: log line"])
47+
end
48+
3949
it "should log error messages" do
4050
Rdkafka::Bindings::LogCallback.call(nil, 3, nil, "log line")
4151
expect(log_queue).to have_received(:<<).with([Logger::ERROR, "rdkafka: log line"])
@@ -51,6 +61,11 @@
5161
expect(log_queue).to have_received(:<<).with([Logger::INFO, "rdkafka: log line"])
5262
end
5363

64+
it "should log info messages" do
65+
Rdkafka::Bindings::LogCallback.call(nil, 6, nil, "log line")
66+
expect(log_queue).to have_received(:<<).with([Logger::INFO, "rdkafka: log line"])
67+
end
68+
5469
it "should log debug messages" do
5570
Rdkafka::Bindings::LogCallback.call(nil, 7, nil, "log line")
5671
expect(log_queue).to have_received(:<<).with([Logger::DEBUG, "rdkafka: log line"])

0 commit comments

Comments
 (0)