Skip to content

Commit c1123f9

Browse files
authored
Fix children of driver buttons not triggering click events (#560)
* Fix children of driver buttons not triggering click events * Replace custom function with Element.closest()
1 parent 6aea011 commit c1123f9

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/popover.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ export function renderPopover(element: Element, step: DriveStep) {
161161
const onPrevClick = step.popover?.onPrevClick || getConfig("onPrevClick");
162162
const onCloseClick = step.popover?.onCloseClick || getConfig("onCloseClick");
163163

164-
if (target.classList.contains("driver-popover-next-btn")) {
164+
if (!!target.closest(".driver-popover-next-btn")) {
165165
// If the user has provided a custom callback, call it
166166
// otherwise, emit the event.
167167
if (onNextClick) {
@@ -175,7 +175,7 @@ export function renderPopover(element: Element, step: DriveStep) {
175175
}
176176
}
177177

178-
if (target.classList.contains("driver-popover-prev-btn")) {
178+
if (!!target.closest(".driver-popover-prev-btn")) {
179179
if (onPrevClick) {
180180
return onPrevClick(element, step, {
181181
config: getConfig(),
@@ -187,7 +187,7 @@ export function renderPopover(element: Element, step: DriveStep) {
187187
}
188188
}
189189

190-
if (target.classList.contains("driver-popover-close-btn")) {
190+
if (!!target.closest(".driver-popover-close-btn")) {
191191
if (onCloseClick) {
192192
return onCloseClick(element, step, {
193193
config: getConfig(),

0 commit comments

Comments
 (0)