Skip to content

Commit 8e851ec

Browse files
committed
chore: fix hrefs and add missing accessibility attributes
The changes improve internal link paths and accessibility by: - Updating badge href paths to use absolute format - Adding ID attribute for page navigation - Adding proper aria-disabled attribute to Note component
1 parent 018710b commit 8e851ec

File tree

4 files changed

+20
-16
lines changed

4 files changed

+20
-16
lines changed

src/docs/data/badge.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -155,13 +155,13 @@ import { LogoSlackColor } from 'kampsy-ui/icons';
155155
156156
<div class="flex flex-col gap-4">
157157
<div class="flex items-center gap-2 capitalize">
158-
<Badge href="#badge#pill" size="small" variant="pill" aria-label="large pill">label</Badge>
159-
<Badge href="#badge#pill" size="medium" variant="pill" aria-label="medium pill">label</Badge>
160-
<Badge href="#badge#pill" size="large" variant="pill" aria-label="small pill">label</Badge>
158+
<Badge href="/badge#pill" size="small" variant="pill" aria-label="large pill">label</Badge>
159+
<Badge href="/badge#pill" size="medium" variant="pill" aria-label="medium pill">label</Badge>
160+
<Badge href="/badge#pill" size="large" variant="pill" aria-label="small pill">label</Badge>
161161
</div>
162162
<div class="flex items-center gap-2 capitalize">
163-
<Badge href="#badge#pill" icon={LogoSlackColor} size="small" variant="pill" aria-label="icon large pill">label</Badge>
164-
<Badge href="#badge#pill" icon={LogoSlackColor} size="medium" variant="pill" aria-label="icon medium pill">label</Badge>
165-
<Badge href="#badge#pill" icon={LogoSlackColor} size="large" variant="pill" aria-label="icon small pill">label</Badge>
163+
<Badge href="/badge#pill" icon={LogoSlackColor} size="small" variant="pill" aria-label="icon large pill">label</Badge>
164+
<Badge href="/badge#pill" icon={LogoSlackColor} size="medium" variant="pill" aria-label="icon medium pill">label</Badge>
165+
<Badge href="/badge#pill" icon={LogoSlackColor} size="large" variant="pill" aria-label="icon small pill">label</Badge>
166166
</div>
167167
</div>`;

src/docs/ui/linkH2.svelte

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,20 @@
11
<script lang="ts">
22
import type { Snippet } from 'svelte';
3-
import type { HTMLAttributes } from 'svelte/elements';
3+
import type { HTMLAnchorAttributes } from 'svelte/elements';
44
import Link from '$lib/icons/link.svelte';
55
6-
interface Props extends HTMLAttributes<HTMLAnchorElement> {
6+
interface Props extends HTMLAnchorAttributes {
77
href: string;
88
children: Snippet;
99
}
1010
1111
let { href, children, ...rest }: Props = $props();
12+
13+
// id for page navigation
14+
const id = href.split('#').pop();
1215
</script>
1316

14-
<a {href} class="no-underline outline-none relative -ml-5 pl-5 inline-block group" {...rest}>
17+
<a {href} {id} class="no-underline outline-none relative -ml-5 pl-5 inline-block group" {...rest}>
1518
<h2
1619
class="first-letter:capitalize text-kui-light-gray-1000 dark:text-kui-dark-gray-1000 text-[24px] font-semibold leading-[32px] tracking-[-0.96px]"
1720
>

src/lib/note/note.svelte

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,8 @@
135135
<div class="w-full">
136136
<div
137137
class="w-full space-y-2 md:space-y-0 md:flex md:items-center md:justify-between lg:gap-x-3
138-
{disabled}
138+
class:disabled={disabled}
139+
aria-disabled={disabled}
139140
{contClass} {radiusClass} {sizeClass} {klass}"
140141
{...rest}
141142
>

src/routes/badge/+page.svelte

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -428,33 +428,33 @@
428428
{#snippet demo()}
429429
<div class="flex flex-col gap-4">
430430
<div class="flex items-center gap-2 capitalize">
431-
<Badge href="#badge#pill" size="small" variant="pill" aria-label="large pill"
431+
<Badge href="/badge#pill" size="small" variant="pill" aria-label="large pill"
432432
>label</Badge
433433
>
434-
<Badge href="#badge#pill" size="medium" variant="pill" aria-label="medium pill"
434+
<Badge href="/badge#pill" size="medium" variant="pill" aria-label="medium pill"
435435
>label</Badge
436436
>
437-
<Badge href="#badge#pill" size="large" variant="pill" aria-label="small pill"
437+
<Badge href="/badge#pill" size="large" variant="pill" aria-label="small pill"
438438
>label</Badge
439439
>
440440
</div>
441441
<div class="flex items-center gap-2 capitalize">
442442
<Badge
443-
href="#badge#pill"
443+
href="/badge#pill"
444444
icon={LogoSlackColor}
445445
size="small"
446446
variant="pill"
447447
aria-label="icon large pill">label</Badge
448448
>
449449
<Badge
450-
href="#badge#pill"
450+
href="/badge#pill"
451451
icon={LogoSlackColor}
452452
size="medium"
453453
variant="pill"
454454
aria-label="icon medium pill">label</Badge
455455
>
456456
<Badge
457-
href="#badge#pill"
457+
href="/badge#pill"
458458
icon={LogoSlackColor}
459459
size="large"
460460
variant="pill"

0 commit comments

Comments
 (0)