Skip to content

Usage of "falvor" instead of "flavor" in 1 visible place and multiple other files in code #9550

@bluikko

Description

@bluikko

Bug report

Please provide a detailed description of the issue and the steps to reproduce:
One of the conversion profiles has what seems to be a typo: "falvors" - shouldn't this be "flavors"?
It is visible in the management console.

Afterwards I noticed that the same "falvor" is present in:

  • flavorParamsAction.class.php
  • KDLWrap.php
  • commands.cfg.template
  • cluster_commands.cfg.template
  • myEntryUtils.class.php

Since there are so many occurrences of the "typo", it cannot just be a simple typo. Either:

  • Someone does not know how to spell "flavor".
  • In this context "falvor" is something I've never heard of before.

If it is the former then question is is it safe to change the templates or would this affect already existing installations that are updated?
Most likely the code could be fixed without issues.

I opened a PR at #9536 but quickly saw that the initial PR is wrong since it is enough to just change "INGESTED_FALVORS" to "INGESTED_FLAVORS" without fixing other files also. So the PR must not be merged!

Kaltura ENV

Please fill out this section if you are hosting the Kaltura platform on your own servers [as opposed to using Kaltura SaaS]. In the event of SaaS, the below should be deleted.

Relevant errors from /opt/kaltura/log/kaltura_api_v3.log, /opt/kaltura/log/kaltura_apache_errors*log and /opt/kaltura/log/kaltura_prod.log:
irrelevant

Linux distribution name and version:
git MASTER

Are you using the RPM or deb packages?

  • RPM
  • deb

When using RPM, paste the output for:

# rpm -qa "kaltura-*"
irrelevant

For deb based systems:

# dpkg -l "kaltura-*"
irrelevant

Is this an all in one instance [single server] or a cluster?

  • All in one
  • Cluster

If applicable, please provide the MySQL version:
irrelevant

If you're having an issue with a specific media asset, please provide a link from which it can be downloaded/played:
irrelevant

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions