Fix libopenblas related issues in configuration #4978
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running the configuration, two issues can arise: 1. The script searches for the OpenBLAS libraries in ./tools/OpenBLAS/install yet the default scripts lead to this being created in ./tools/extras/OpenBLAS/install 2. When compiling statically, the flag for -lgfortran is added without space, leading to the configuration trying to link -l:libopenblas.a-lgfortran as one string
|
Thank you, merging. |
|
tests are failing but not because of your changes, I will merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the configuration, two issues can arise: