Skip to content

Commit a2009cc

Browse files
kaiseroOliver Kaiser
and
Oliver Kaiser
authored
v1.0.8 (#52)
* v1.0.5 * v1.0.6 * v1.0.7 * fixed missing hitcount filter impl Co-authored-by: Oliver Kaiser <ok@on.at>
1 parent 69bef1a commit a2009cc

File tree

4 files changed

+7
-4
lines changed

4 files changed

+7
-4
lines changed

fireREST/fmc/object/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
from fireREST.fmc import Connection, Resource
1+
from fireREST.fmc import Connection
22
from fireREST.fmc.object.anyprotocolportobject import AnyProtocolPortObject
33
from fireREST.fmc.object.anyconnectcustomattribute import AnyconnectCustomAttribute
44
from fireREST.fmc.object.anyconnectpackage import AnyconnectPackage

fireREST/fmc/policy/accesspolicy/operational/hitcounts/__init__.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ class Hitcount(ChildResource):
88
CONTAINER_NAME = 'AccessPolicy'
99
CONTAINER_PATH = '/policy/accesspolicies/{uuid}'
1010
PATH = '/policy/accesspolicies/{container_uuid}/operational/hitcounts/{uuid}'
11-
SUPPORTED_FILTERS = []
11+
SUPPORTED_FILTERS = ['device_id', 'ids', 'fetch_zero_hitcount']
1212
SUPPORTED_PARAMS = []
1313
MINIMUM_VERSION_REQUIRED_GET = '6.4.0'
1414
MINIMUM_VERSION_REQUIRED_UPDATE = '6.4.0'
@@ -19,8 +19,8 @@ def update(self):
1919
return
2020

2121
@utils.support_params
22-
def get(self):
23-
return
22+
def get(self, container_uuid, device_id=None, ids=None, fetch_zero_hitcount=None, params=None):
23+
return super().get(container_uuid, params=params)
2424

2525
@utils.support_params
2626
def delete(self):

fireREST/mapping.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -230,6 +230,8 @@
230230
'original_destination_port': 'originalDestinationPort',
231231
'translated_source_port': 'translatedSourcePort',
232232
'translated_destination_port': 'translatedDestinationPort',
233+
'ids': 'ids',
234+
'fetch_zero_hitcount': 'fetchZeroHitCount',
233235
}
234236

235237
PARAMS = {

fireREST/utils.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -258,6 +258,7 @@ def search_filter(items=None):
258258
for item in items:
259259
for k, v in item.items():
260260
if v:
261+
v = str(v).lower() if type(v) == bool else v
261262
filter_str += f'{k}:{v};'
262263
return filter_str.rstrip(';')
263264
return ''

0 commit comments

Comments
 (0)