Skip to content

Commit 12ec15f

Browse files
authored
v. 0.1.2 (#25)
1 parent 32bdab0 commit 12ec15f

File tree

3 files changed

+20
-7
lines changed

3 files changed

+20
-7
lines changed

CHANGELOG.md

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,16 @@
1+
# 0.1.3
2+
3+
## Bugfixes
4+
5+
Fixed missing conversion from dict to json in _request helper
6+
7+
# 0.1.2
8+
9+
## Bugfixes
10+
11+
Corrected api call for getting audit records (#24)
12+
Corrected incorrect base api calls by removing positional args (#23)
13+
114
# 0.1.1
215

316
## Enhancements

fireREST/__init__.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ def _request(self, method: str, url: str, params=None, auth=None, data=None):
9696
method=method,
9797
url=url,
9898
params=params,
99-
data=data,
99+
data=json.dumps(data),
100100
auth=auth,
101101
headers=self.headers,
102102
timeout=self.timeout,
@@ -123,7 +123,7 @@ def _get(self, url: str, params=None, items=None):
123123
params['limit'] = defaults.API_PAGING_LIMIT
124124
params['expanded'] = defaults.API_EXPANSION_MODE
125125

126-
response = self._request('get', url, params)
126+
response = self._request('get', url, params=params)
127127
payload = response.json()
128128

129129
if 'paging' in payload:
@@ -171,7 +171,7 @@ def _delete(self, url: str, params=None):
171171
: param params: dict of parameters for http request
172172
: return: requests.Response object
173173
'''
174-
return self._request('delete', url, params)
174+
return self._request('delete', url, params=params)
175175

176176
def _create(self, url: str, data: Dict, params=None):
177177
'''
@@ -182,7 +182,7 @@ def _create(self, url: str, data: Dict, params=None):
182182
: return: requests.Response object
183183
'''
184184
data = self._sanitize(data)
185-
return self._request('post', url, params, data)
185+
return self._request('post', url, params=params, data=data)
186186

187187
def _update(self, url: str, data: Dict, params=None):
188188
'''
@@ -193,7 +193,7 @@ def _update(self, url: str, data: Dict, params=None):
193193
: return: requests.Response object
194194
'''
195195
data = self._sanitize(data)
196-
return self._update(url, data, params)
196+
return self._request(url, data=data, params=params)
197197

198198
def _sanitize(self, payload: Dict):
199199
'''
@@ -388,7 +388,7 @@ def get_system_version(self):
388388

389389
@utils.minimum_version_required('6.1.0')
390390
def get_audit_records(self):
391-
url = self._url('platform', '/audit/auditrecords')
391+
url = self._url('config', '/audit/auditrecords')
392392
return self._get(url)
393393

394394
@utils.minimum_version_required('6.1.0')

fireREST/version.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
__version__ = '0.1.1'
1+
__version__ = '0.1.3'

0 commit comments

Comments
 (0)