Add some more function tests

Just to get over 90%

Author: k5cents

R/combine.R

@@ -15,12 +15,19 @@ combine_history <- function(fun, ...) {
   if (!("leagueHistory" %in% names(formals(fun)))) {
     stop("leagueHistory is not an argument of this function")
   }
-  old <- bind_df(fun(..., leagueHistory = TRUE), .id = NULL)
+  old <- fun(..., leagueHistory = TRUE)
+  if (inherits(old, "data.frame")) {
+    message("Historical data is already a data.frame")
+    return(old)
+  } else {
+    old <- bind_df(old, .id = NULL)
+  }
   new <- fun(..., leagueHistory = FALSE)
   n_old <- ncol(old)
   n_new <- ncol(new)
   if (n_new > n_old) {
     old <- balance_col(old, new)
+    new <- balance_col(new, old)
   } else if (n_old > n_new) {
     new <- balance_col(new, old)
   }

R/members.R

@@ -15,7 +15,7 @@ league_members <- function(leagueId = ffl_id(), leagueHistory = FALSE, ...) {
     ...
   )
   if (leagueHistory && is.list(dat$teams)) {
-    names(dat$teams) <- dat$seasonId
+    names(dat$members) <- dat$seasonId
     lapply(dat$members, out_member)
   } else {
     out_member(dat$members)

R/utils.R

@@ -63,13 +63,13 @@ change_names <- function(dat, old_name, new_name) {
   return(dat)
 }
 
-replace_col <- function(z, old_name, ...) {
-  dots <- list(...)
-  stopifnot(length(dots) == 1, old_name %in% names(z))
-  z[[old_name]] <- dots[[1]]
-  z <- change_names(z, old_name, names(dots)[[1]])
-  return(z)
-}
+# replace_col <- function(z, old_name, ...) {
+#   dots <- list(...)
+#   stopifnot(length(dots) == 1, old_name %in% names(z))
+#   z[[old_name]] <- dots[[1]]
+#   z <- change_names(z, old_name, names(dots)[[1]])
+#   return(z)
+# }
 
 col_abbrev <- function(z, col, new) {
   new_name <- gsub("Id$", "", col)

tests/testthat/test-history.R

@@ -7,3 +7,12 @@ test_that("historical data can be returned", {
   expect_length(h, 1)
   expect_s3_class(h[[1]], "data.frame")
 })
+
+test_that("historical data can be combined", {
+  h <- combine_history(
+    fun = league_simulation,
+    leagueId = "42654852"
+  )
+  expect_s3_class(h, "data.frame")
+  expect_length(h, 12)
+})

tests/testthat/test-members.R

@@ -3,3 +3,11 @@ test_that("league members", {
   expect_s3_class(m, "data.frame")
   expect_length(m, 3)
 })
+
+test_that("league members history with names", {
+  m <- league_members(leagueId = "42654852", leagueHistory = TRUE)
+  expect_type(m, "list")
+  expect_named(m)
+  expect_s3_class(m[[1]], "data.frame")
+  expect_length(m[[1]], 3)
+})

tests/testthat/test-outlook.R

@@ -1,6 +1,6 @@
 test_that("get individual player outlook", {
   o <- player_outlook(
-    leagueId = "42654852",
+    leagueId = NULL,
     limit = 1
   )
   expect_s3_class(o, "data.frame")

tests/testthat/test-scores.R

@@ -15,3 +15,13 @@ test_that("scores by scoring period", {
   )
   expect_equal(length(unique(s$scoringPeriodId)), nrow(s)/4)
 })
+
+test_that("scores by past league history", {
+  s <- tidy_scores(
+    leagueId = "42654852",
+    leagueHistory = TRUE,
+    useMatchup = TRUE
+  )
+  expect_type(s, "list")
+  expect_length(unique(s[[1]]$matchupPeriodId), 17)
+})

tests/testthat/test-settings.R

@@ -67,6 +67,13 @@ test_that("roster settings for a single season", {
   expect_s3_class(r$lineupSlotCounts[[1]], "data.frame")
 })
 
+test_that("roster settings for a past seasons", {
+  r <- roster_settings("42654852", leagueHistory = TRUE)
+  expect_s3_class(r, "data.frame")
+  expect_length(r, 8)
+  expect_s3_class(r$lineupSlotCounts[[1]], "data.frame")
+})
+
 # schedule settings -------------------------------------------------------
 Sys.sleep(runif(1, 1, 2))
 

tests/testthat/test-simulation.R

@@ -0,0 +1,7 @@
+test_that("get simulated season projections", {
+  s <- league_simulation(
+    leagueId = "42654852"
+  )
+  expect_s3_class(s, "data.frame")
+  expect_length(s, 11)
+})