Adjust tests for end of 2023 season

Kiernan Nicholls · Kiernan Nicholls · commit b1f86e41bd99 · 2024-01-12T15:11:50.000-05:00
diff --git a/CRAN-SUBMISSION b/CRAN-SUBMISSION
@@ -0,0 +1,3 @@
+Version: 2.2.1
+Date: 2024-01-12 20:11:38 UTC
+SHA: 8143003625d36d803c54e1b6ea5fa03b8e9de8fb
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,6 +1,6 @@
 Package: fflr
 Title: Retrieve ESPN Fantasy Football Data
-Version: 2.2.0.9002
+Version: 2.2.1
 Authors@R: 
     person("Kiernan", "Nicholls", , "kiernann@protonmail.com", role = c("aut", "cre", "cph"))
 Description: Format the raw data from the ESPN fantasy football API
diff --git a/NEWS.md b/NEWS.md
@@ -1,5 +1,6 @@
-# fflr (development version)
+# fflr 2.2.1
 
+* Adjust tests for end of NFL season.
 * The functions `league_members()` and `league_teams()` have been adjusted to
   add new columns. The order of columns has also been rearranged to focus on
   the output of each function (all teams or all members), since some teams can
diff --git a/cran-comments.md b/cran-comments.md
@@ -14,4 +14,4 @@
 
 ## Resubmission
 
-* Fixed broken link to https://kiernann.com/fflr in README
+* Updated test to account for end of the 2023 NFL season.
diff --git a/tests/testthat/test-best.R b/tests/testthat/test-best.R
@@ -17,7 +17,7 @@ test_that("calculate best possible future roster", {
   b <- best_roster(
     leagueId = "42654852",
     useScore = "projectedScore",
-    scoringPeriodId = ffl_week()
+    scoringPeriodId = 1
   )
   b2 <- b[[2]]
   expect_s3_class(b2, "data.frame")
diff --git a/tests/testthat/test-events.R b/tests/testthat/test-events.R
@@ -1,8 +1,8 @@
 test_that("get NFL game schedule times", {
   e <- pro_events()
   expect_s3_class(e, "data.frame")
-  expect_type(e$competitors, "list")
-  expect_length(e, 13)
+  # expect_type(e$competitors, "list")
+  expect_length(e, 7)
 })
 
 test_that("get NFL game scores", {

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+Version: 2.2.1`
	`2`	`+Date: 2024-01-12 20:11:38 UTC`
	`3`	`+SHA: 8143003625d36d803c54e1b6ea5fa03b8e9de8fb`
Original file line number	Diff line number	Diff line change
`@@ -14,4 +14,4 @@`
`14`	`14`
`15`	`15`	`## Resubmission`
`16`	`16`
`17`		`-* Fixed broken link to https://kiernann.com/fflr in README`
	`17`	`+* Updated test to account for end of the 2023 NFL season.`
Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@ test_that("calculate best possible future roster", {`
`17`	`17`	`b <- best_roster(`
`18`	`18`	`leagueId = "42654852",`
`19`	`19`	`useScore = "projectedScore",`
`20`		`- scoringPeriodId = ffl_week()`
	`20`	`+ scoringPeriodId = 1`
`21`	`21`	`)`
`22`	`22`	`b2 <- b[[2]]`
`23`	`23`	`expect_s3_class(b2, "data.frame")`