Skip to content

Commit 04834bf

Browse files
committed
Release 0.3.12 to CRAN
1 parent b42b9b9 commit 04834bf

File tree

2 files changed

+20
-6
lines changed

2 files changed

+20
-6
lines changed

CRAN-RELEASE

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
This package was submitted to CRAN on 2020-11-05.
2+
Once it is accepted, delete this file and tag the release (commit b42b9b9).

cran-comments.md

Lines changed: 18 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,18 +8,32 @@
88
* win-builder: windows-x86_64-devel
99
* https://win-builder.r-project.org/ANV0wwGa2RnH/
1010
* r-hub: windows-x86_64-devel, ubuntu-gcc-release, fedora-clang-devel
11-
* https://builder.r-hub.io/status/fflr_0.3.10.tar.gz-8880c48e9fb3456d9237301782b6253c
12-
* https://builder.r-hub.io/status/fflr_0.3.10.tar.gz-93d173f6f5e64628b4f0703a611f3664
13-
* https://builder.r-hub.io/status/fflr_0.3.10.tar.gz-4c5998ea86dd4127824cdc5736210ecf
11+
* https://builder.r-hub.io/status/fflr_0.3.12.tar.gz-b850b4a77c694edbb30f071e6230e021
12+
* https://builder.r-hub.io/status/fflr_0.3.12.tar.gz-c251fe8fcb3e4b3d950a44d28bd2f9d8
13+
* https://builder.r-hub.io/status/fflr_0.3.12.tar.gz-ab2074eef0d940d099c778c177ab8d04
1414

1515
## R CMD check results
1616

17-
0 errors | 0 warnings | 1 note
17+
0 errors | 0 warnings | 0 notes
1818

1919
* This is a new release.
2020

2121
## Resubmission
2222

23+
* _All_ calls to an external API use `tryCatch()` and repeat the request should
24+
it fail initially. The timeout options are no longer changed between attempts,
25+
only sleeping.
26+
27+
* The `all_players()` examples and tests are skipped because they take too long.
28+
The stat scraping is also more careful when handling edge cases and should be
29+
able to run at any time.
30+
31+
* The vignette uses a know, past data point and no longer changes depending on
32+
when it was run; this should prevent calls to `team_roster()`, etc from
33+
returning some data that might not work in the rest of the vignette.
34+
35+
## Previous Submission
36+
2337
* The `ffl_api()` now uses `tryCatch()` and re-tries to call the API when it
2438
fails, waiting with `Sys.sleep()` between attempts and adjusting the timeout
2539
`options()`. This should help prevent timeout failures in
@@ -31,8 +45,6 @@ fails, waiting with `Sys.sleep()` between attempts and adjusting the timeout
3145
Timeout was reached: [fantasy.espn.com] Resolving timed out after 10001 milliseconds
3246
```
3347

34-
## Previous Submission
35-
3648
* [ESPN](https://en.wikipedia.org/wiki/ESPN) is not really an acronym, it no
3749
longer stands for anything and doesn't need to be explained in the DESCRIPTION.
3850

0 commit comments

Comments
 (0)