found a bug about scan mysql rows

[wangyanphp]

https://github.com/k3s-io/kine/blob/master/pkg/logstructured/sqllog/sql.go#L353

it should check rows.Error when finished rows.Next loop

[brandond]

Can you show an error caused by not doing this? Or some way to cause one?

[wangyanphp]

Can you show an error caused by not doing this? Or some way to cause one?

mysql error code 1160 can cause this

[brandond]

In case of a communication problem with the sql server, there would be additional errors that are handled outside the row iterator, right?

[wangyanphp]

In case of a communication problem with the sql server, there would be additional errors that are handled outside the row iterator, right?

yes