From 44bc2659a04494a2b7c5213699e304567591914f Mon Sep 17 00:00:00 2001 From: Fangjun Kuang Date: Wed, 22 May 2024 19:52:22 +0800 Subject: [PATCH 1/2] Fix reading wave files generated by NAudio. --- sherpa-onnx/csrc/wave-reader.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sherpa-onnx/csrc/wave-reader.cc b/sherpa-onnx/csrc/wave-reader.cc index 98d34fb75e..f33f3a5434 100644 --- a/sherpa-onnx/csrc/wave-reader.cc +++ b/sherpa-onnx/csrc/wave-reader.cc @@ -36,7 +36,8 @@ struct WaveHeader { return false; } - if (subchunk1_size != 16) { // 16 for PCM + // NAudio uses 18 + if (subchunk1_size != 16 && subchunk1_size != 18) { // 16 for PCM SHERPA_ONNX_LOGE("Expected subchunk1_size 16. Given: %d\n", subchunk1_size); return false; From b21af190c4355c47cd1f3410066df0299538cc8b Mon Sep 17 00:00:00 2001 From: Fangjun Kuang Date: Wed, 22 May 2024 19:55:26 +0800 Subject: [PATCH 2/2] add a note --- sherpa-onnx/csrc/wave-reader.cc | 1 + 1 file changed, 1 insertion(+) diff --git a/sherpa-onnx/csrc/wave-reader.cc b/sherpa-onnx/csrc/wave-reader.cc index f33f3a5434..66f1cb12e0 100644 --- a/sherpa-onnx/csrc/wave-reader.cc +++ b/sherpa-onnx/csrc/wave-reader.cc @@ -37,6 +37,7 @@ struct WaveHeader { } // NAudio uses 18 + // See https://github.com/naudio/NAudio/issues/1132 if (subchunk1_size != 16 && subchunk1_size != 18) { // 16 for PCM SHERPA_ONNX_LOGE("Expected subchunk1_size 16. Given: %d\n", subchunk1_size);